-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
refactorRefactor and re-architecture ideasRefactor and re-architecture ideas
Description
The name name is problematic since it should be unique and used for internal purposes. More like a reference or id.
This refactor can be done while keeping back compatible (for now) by creating a @property called name that points to func_id.
Other name option: fid.
Could also have a **kwargs that keeps the possibility for using name in __init__ but I'd rather not.
Further (perhaps this should be a separate issue?) we may want to use func_id instead of the FuncNode instance itself in the DAG.graph. It's more readable, and less problems with hashing, sorting, etc.
Metadata
Metadata
Assignees
Labels
refactorRefactor and re-architecture ideasRefactor and re-architecture ideas