forked from realm/SwiftLint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathBlockBasedKVORule.swift
81 lines (71 loc) · 3.04 KB
/
BlockBasedKVORule.swift
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
//
// BlockBasedKVORule.swift
// SwiftLint
//
// Created by Marcelo Fabri on 07/27/17.
// Copyright © 2017 Realm. All rights reserved.
//
import Foundation
import SourceKittenFramework
public struct BlockBasedKVORule: ASTRule, ConfigurationProviderRule {
public var configuration = SeverityConfiguration(.warning)
public init() {}
public static let description = RuleDescription(
identifier: "block_based_kvo",
name: "Block Based KVO",
description: "Prefer the new block based KVO API with keypaths when using Swift 3.2 or later.",
kind: .idiomatic,
nonTriggeringExamples: [
"let observer = foo.observe(\\.value, options: [.new]) { (foo, change) in\n" +
" print(change.newValue)\n" +
"}"
],
triggeringExamples: [
"class Foo: NSObject {\n" +
" override ↓func observeValue(forKeyPath keyPath: String?, of object: Any?,\n" +
" change: [NSKeyValueChangeKey : Any]?,\n" +
" context: UnsafeMutableRawPointer?) {}\n" +
"}",
"class Foo: NSObject {\n" +
" override ↓func observeValue(forKeyPath keyPath: String?, of object: Any?,\n" +
" change: Dictionary<NSKeyValueChangeKey, Any>?,\n" +
" context: UnsafeMutableRawPointer?) {}\n" +
"}"
]
)
public func validate(file: File, kind: SwiftDeclarationKind,
dictionary: [String: SourceKitRepresentable]) -> [StyleViolation] {
guard SwiftVersion.current >= .four, kind == .functionMethodInstance,
dictionary.enclosedSwiftAttributes.contains("source.decl.attribute.override"),
dictionary.name == "observeValue(forKeyPath:of:change:context:)",
hasExpectedParamTypes(types: dictionary.enclosedVarParameters.parameterTypes),
let offset = dictionary.offset else {
return []
}
return [
StyleViolation(ruleDescription: type(of: self).description,
severity: configuration.severity,
location: Location(file: file, byteOffset: offset))
]
}
private func hasExpectedParamTypes(types: [String]) -> Bool {
guard types.count == 4,
types[0] == "String?",
types[1] == "Any?",
types[2] == "[NSKeyValueChangeKey:Any]?" || types[2] == "Dictionary<NSKeyValueChangeKey,Any>?",
types[3] == "UnsafeMutableRawPointer?" else {
return false
}
return true
}
}
private extension Array where Element == [String: SourceKitRepresentable] {
var parameterTypes: [String] {
return flatMap { element in
guard element.kind.flatMap(SwiftDeclarationKind.init) == .varParameter else {
return nil
}
return element.typeName?.replacingOccurrences(of: " ", with: "")
}
}
}