Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on positive/negative click behaviour #2

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

labrunhosarodrigues
Copy link

Missing date argument in markAs(Non)Target calls in the positive/negative divs click event definitions was making it impossible to submit answers through clicking, which is important if I want to try and apply the test in a mobile setting.

This pull request fixes that.

Fixed bug that prevented clicking the buttons to register participant answers.

markAsTarget() and markAsNonTarget() on positive and negative divs click events were missing the Date argument, so clicking them to submit answers was not possible. This patch fixes that.
Copy to clipboard was not working properly, this fix allows it to actually copy the text from results to the clipboard
In some settings it might be unfeasible to copy the results and past them for file storage, an option to simply download a timestamped JSON file is proposed.
@labrunhosarodrigues
Copy link
Author

Added more fixes, now on results storing part

0-back task was setting every stimulus as a target. This was fixed to generate a target number of characters 'X',  with all other characters being non-targets.
@labrunhosarodrigues
Copy link
Author

Added also a fix to the implementation of 0-back task, now a targetSize number of 'X' characters are presented, and the other characters are marked as non-target

@labrunhosarodrigues
Copy link
Author

Hello @iROCKBUNNY, I saw that you implemented most what I suggested in this pull request.

Would you consider adding also the json download option?
That would allow easy data collection in mobile settings, with a tablet or smartphone, where copying and pasting the results into a file is not as convenient as in a computer.

Thanks!

@iROCKBUNNY
Copy link
Contributor

@labrunhosarodrigues Thank you for your advices. I may address JSON download feature when I have time available.

@iROCKBUNNY iROCKBUNNY self-assigned this Nov 2, 2023
@labrunhosarodrigues
Copy link
Author

@labrunhosarodrigues Thank you for your advices. I may address JSON download feature when I have time available.

Let me know if I can be of assistance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants