Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to dev.iscsc.fr fails on forks #67

Open
ctmbl opened this issue Jun 24, 2024 · 0 comments
Open

Deploy to dev.iscsc.fr fails on forks #67

ctmbl opened this issue Jun 24, 2024 · 0 comments
Labels
bug Something isn't working idle Will wait for further development or information

Comments

@ctmbl
Copy link
Contributor

ctmbl commented Jun 24, 2024

Context

#61 introduced a semi-manual (needs approval) workflow to deploy to the preview website at https://dev.iscsc.fr in order to share PR changes with others without having to clone and deploy locally.

Problem

This deploying workflow needs some repo secret, the ssh key for example, but secrets are not exposed to pull requests opened from forks for security reasons this leads to the workflow failing when triggered from forks.
see also:

Workaround

currently the only solution is to push the branch to the origin repo (for users with write perms) and trigger the workflow manually

Solution

https://michaelheap.com/access-secrets-from-forks/

@ctmbl ctmbl added bug Something isn't working idle Will wait for further development or information labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working idle Will wait for further development or information
Projects
None yet
Development

No branches or pull requests

1 participant