Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity request failures not logged as errors #1

Open
iaincollins opened this issue Oct 4, 2018 · 0 comments
Open

Entity request failures not logged as errors #1

iaincollins opened this issue Oct 4, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@iaincollins
Copy link
Owner

if the cache is reset then it will force the script to update all metadata for all guests from the Wikipedia API.

This will trigger > 1000 API requests. Although it will make the requests synchronously, to reduce the impact of hitting rate limits, some of which may still fail and the guests will subsequently be recorded as party "Unknown" as it will have no metadata for them.

For now this currently mitigated by running the script twice if the cache is ever rebuilt from scratch and checking the cache size to ensure it's at least as large as it was before.

This issue can be resolved by changing the command line interface to save the data directly to an output file rather than having to be concatenated into a file, allowing errors to be logged to the console (without impacting the data output to CSV).

@iaincollins iaincollins added the bug Something isn't working label Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant