Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component props type and update tests #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheMatrixan
Copy link

  • I removed any types from the function and replaced them with React type utils.
  • I added JSDoc to make it easier to use in development - developer will be able to see how to use this function without leaving VSCode.
  • I added Given-When-Then to tests to make them more readable.

@nikeee
Copy link

nikeee commented Jan 16, 2024

Can I help getting this PR merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants