Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GPU performance #25

Open
ibab opened this issue Sep 17, 2016 · 6 comments
Open

Improve GPU performance #25

ibab opened this issue Sep 17, 2016 · 6 comments

Comments

@ibab
Copy link
Owner

ibab commented Sep 17, 2016

The performance of the network on GPUs seems to be lagging behind the CPU performance.
I suspect that this is because the 2D convolution isn't designed to work efficiently if the height of the input is 1.
It shouldn't be too difficult to write some custom code to perform an efficient 1D convolution.
For example, fft could be used for this.

@bhack
Copy link

bhack commented Sep 18, 2016

@ibab ibab removed the performance label Sep 20, 2016
@ibab
Copy link
Owner Author

ibab commented Sep 20, 2016

Just compared GPU and CPU again, and this time training is significantly faster on the GPU.

@lemonzi
Copy link
Collaborator

lemonzi commented Oct 6, 2016

Is this solved then?

@ibab
Copy link
Owner Author

ibab commented Oct 6, 2016

We would probably be able to train larger networks (and with larger sample sizes) if we had a single C++ op that does causal 1d convolution, as we would be able to avoid all the extra copying that's currently being done.
But writing and maintaining the op might be a pain :/

@lemonzi
Copy link
Collaborator

lemonzi commented Oct 6, 2016

I've done it before, but not with gpu support...

On Thu, Oct 6, 2016, 18:58 Igor Babuschkin [email protected] wrote:

We would probably be able to train larger networks (and with larger sample
sizes) if we had a single C++ op that does causal 1d convolution, as we
would be able to avoid all the extra copying that's currently being done.
But writing and maintaining the op might be a pain :/


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#25 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADCF5gay3mfBQ0wKyF2mamL0xFbu5kq9ks5qxX0mgaJpZM4J_k-r
.

@vinhngx
Copy link

vinhngx commented Aug 16, 2019

@ibab I've made a pull request for mixed precision training
#384

and would like to encourage the authors and community to give it a try :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants