Merge pull request #942 from ibi-group/prior-notice-time-field

Prior_Notice_Last_Time accept Time instead of Number

Author: philip-cline

lib/editor/util/validation.js

@@ -252,6 +252,15 @@ export function validate (
       }
       return false
     case 'TIME':
+      const isValid = moment(value, 'HH:mm:ss', true).isValid()
+      if (isRequiredButEmpty) {
+        return emptyFieldValidationIssue()
+      } else if (!valueDoesNotExist && !isValid) {
+        return validationIssue('Field must be valid time')
+      } else {
+        return false
+      }
+
     case 'NUMBER':
       const isNotANumber = isNaN(value)
       if (isRequiredButEmpty) {

lib/types/reducers.js

@@ -129,9 +129,9 @@ export type EditorTables = {
     pickup_message: string,
     prior_notice_duration_max: number,
     prior_notice_duration_min: number,
-    prior_notice_last_time: number,
+    prior_notice_last_time: Date,
     prior_notice_start_day: number,
-    prior_notice_start_time: number
+    prior_notice_start_time: Date
   }>,
   calendar: Array<{
     description: string,