add dropdown menu and todos

Author: josh-willis-arcadis

lib/editor/components/pattern/EditSettings.js

@@ -5,7 +5,7 @@ import {Alert, Checkbox, Form, FormControl, ControlLabel} from 'react-bootstrap'
 import Rcslider from 'rc-slider'
 
 import {updateEditSetting} from '../../actions/active'
-import {CLICK_OPTIONS} from '../../util'
+import {CLICK_OPTIONS, SNAP_TO_OPTIONS} from '../../util'
 import toSentenceCase from '../../../common/util/text'
 import type {EditSettingsState} from '../../../types/reducers'
 
@@ -64,6 +64,7 @@ export default class EditSettings extends Component<Props, State> {
       stopInterval
     } = editSettings
     const SETTINGS = [
+      // RAIL-TODO remove snap to streets
       {type: 'followStreets', label: 'Snap to streets'},
       {type: 'avoidMotorways', label: 'Avoid highways in routing'},
       {type: 'hideStopHandles', label: 'Hide stop handles'},
@@ -75,6 +76,27 @@ export default class EditSettings extends Component<Props, State> {
     const noSegmentIsActive = !patternSegment && patternSegment !== 0
     return (
       <div>
+        <ControlLabel><small>Snap to options</small></ControlLabel>
+        <FormControl
+          componentClass='select'
+          value={onMapClick}
+          name={'onMapClick'}
+          onChange={this._onSelectChange}>
+          {SNAP_TO_OPTIONS.map(v => {
+            // ADD_STOPS_AT_INTERSECTIONS only enabled for nysdot extenstion
+            // (due to custom r5 deployment)
+            // FIXME: Temporarily disable add stops at intersection entirely
+            // (needs to be fixed for sql editor).
+            const disabled = v === 'ADD_STOPS_AT_INTERSECTIONS' // && !isExtensionEnabled('nysdot')
+            return (
+              <option
+                key={v}
+                disabled={disabled}
+                value={v}>{toSentenceCase(v.replace(/_/g, ' '))}
+              </option>
+            )
+          })}
+        </FormControl>
         {SETTINGS.map((s, i) => (
           <Checkbox
             checked={editSettings[s.type]}

lib/editor/util/index.js

@@ -19,6 +19,11 @@ export const CLICK_OPTIONS: Array<string> = [
   'ADD_STOPS_AT_INTERVAL',
   'ADD_STOPS_AT_INTERSECTIONS'
 ]
+export const SNAP_TO_OPTIONS: Array<string> = [
+  'NONE',
+  'STREET',
+  'RAIL'
+]
 export const YEAR_FORMAT: string = 'YYYY-MM-DD'
 export const EXCEPTION_EXEMPLARS = {
   MONDAY: 0,

lib/scenario-editor/utils/valhalla.js

@@ -216,6 +216,8 @@ export function routeWithGraphHopper (points: Array<LatLng>, avoidMotorways?: bo
   }
 
   // Use custom url if it exists, otherwise default to the hosted service.
+  // RAIL-TODO use default server if no alternates are provided
+  // RAIL-TODO support overiding rail url
   let graphHopperUrl = process.env.GRAPH_HOPPER_URL || 'https://graphhopper.com/api/1/'
   let graphHopperKey = process.env.GRAPH_HOPPER_KEY
 

lib/types/reducers.js

@@ -208,6 +208,7 @@ export type DataState = {
 }
 
 export type EditSettingsState = {
+  // RAIL-TODO add any types that are missing
   addStops: boolean,
   afterIntersection: boolean,
   avoidMotorways: boolean,