Merge pull request #1008 from ibi-group/fix-flex-timetable-editor

Flex: Timetable Editor: Support Flex stop times allowing multiple stop times to have the same times

Author: miles-grant-ibigroup

lib/editor/actions/editor.js

@@ -77,7 +77,7 @@ function getCloneProps (entityId: number, component: string, state: AppState) {
         patternId: newPatternId,
         shapeId: newShapeId,
         shapePoints: pattern.shapePoints.map(sp => ({...sp, shapeId: newShapeId})),
-        patternStopAreas: pattern.stopAreas.map(area => ({...area, patternId: newPatternId})),
+        patternStopAreas: pattern.stopAreas && pattern.stopAreas.map(area => ({...area, patternId: newPatternId})),
         patternLocations: pattern.patternLocations.map(pl => ({...pl, patternId: newPatternId})),
         patternStops: pattern.patternStops.map(ps => ({...ps, patternId: newPatternId}))
       }

lib/editor/selectors/timetable.js

@@ -157,6 +157,7 @@ const isCellValueInvalid = (
   tripIds: Array<string>
 ): ?EditorValidationIssue => {
   const col = columns[colIndex]
+  const isFlexInvolved = columns.some(isFlexStopTime)
 
   if (isTimeFormat(col.type)) {
     // FIXME: This does not yet support validating frequency start/end times.
@@ -176,7 +177,7 @@ const isCellValueInvalid = (
       // Ensure value is increasing over previous value
       // Flexible stop times (because intra zonal trips are represented by a duplicate stop time) can
       // include the same start and end pickup times back to back and so must avoid this check.
-      const isInvalid = !isFlexStopTime(col) && val < previousValue
+      const isInvalid = !isFlexInvolved && val < previousValue
       return isInvalid
         ? {
           field: col.key,