Skip to content

Commit d5977aa

Browse files
PriorNoticeLastTime accept Time instead of Number
1 parent 4d1f6cc commit d5977aa

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

lib/editor/util/validation.js

+9
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,15 @@ export function validate (
252252
}
253253
return false
254254
case 'TIME':
255+
const isValid = moment(value, 'HH:mm:ss', true).isValid()
256+
if (isRequiredButEmpty) {
257+
return emptyFieldValidationIssue()
258+
} else if (!valueDoesNotExist && !isValid) {
259+
return validationIssue('Field must be valid time')
260+
} else {
261+
return false
262+
}
263+
255264
case 'NUMBER':
256265
const isNotANumber = isNaN(value)
257266
if (isRequiredButEmpty) {

lib/types/reducers.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ export type EditorTables = {
129129
pickup_message: string,
130130
prior_notice_duration_max: number,
131131
prior_notice_duration_min: number,
132-
prior_notice_last_time: number,
132+
prior_notice_last_time: time,
133133
prior_notice_start_day: number,
134134
prior_notice_start_time: number
135135
}>,

0 commit comments

Comments
 (0)