Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to PyGithub probably #39

Closed
lostmygithubaccount opened this issue Jan 8, 2024 · 3 comments
Closed

move to PyGithub probably #39

lostmygithubaccount opened this issue Jan 8, 2024 · 3 comments

Comments

@lostmygithubaccount
Copy link
Member

I didn't know this existed (despite looking for a GH Python client several times...), but this looks like it could be used: https://pygithub.readthedocs.io/en/stable/introduction.html

however w/ initial testing, it seems more difficult to extract information out of and might not support GraphQL things we'd want

@lostmygithubaccount
Copy link
Member Author

apparently it does have some GraphQL stuff as of relatively recently -- if we can switch to this it seems better than YOLO-ing w/ raw REST/GraphQL API calls to GitHub

@simkimsia
Copy link

Pygithub was (is?) slow to incorporate PR

I have made a PR to fix certain issues and it sat for ages before getting merged

PyGithub/PyGithub#2090 (comment)

What's the motivation to use pygithub?

@lostmygithubaccount
Copy link
Member Author

What's the motivation to use pygithub?

the main motivation is I don't really like working with GraphQL/GitHub's GraphQL API -- it's hard to get things working and change them. right now, this project is just ending HTTP requests to Github's REST and GraphQL API -- the GraphQL queries are defined here as strings: https://github.com/ibis-project/ibis-analytics/blob/main/dag/graphql_queries.py

I was hoping PyGithub would be a good Python client wrapping these APIs that I could use to get all the same information, but when I did some evaluation it didn't seem to cover all of the things we needed. I'm just going to close this out -- while it might not be the cleanest, the current method works and has been working just fine for many many months now

@lostmygithubaccount lostmygithubaccount closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants