Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(duckdb): add geospatial operations #6399

Closed
1 task done
wybert opened this issue Jun 8, 2023 · 8 comments · Fixed by #7454
Closed
1 task done

feat(duckdb): add geospatial operations #6399

wybert opened this issue Jun 8, 2023 · 8 comments · Fixed by #7454
Assignees
Labels
duckdb The DuckDB backend feature Features or general enhancements geospatial Geospatial related functionality

Comments

@wybert
Copy link

wybert commented Jun 8, 2023

Is your feature request related to a problem?

DuckDB has spatial extension, I would like to see DuckDB spatial support in ibis

Describe the solution you'd like

support all the functions like for PostGIS and HevayAIfunctions

What version of ibis are you running?

5.1

What backend(s) are you using, if any?

DuckDB

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wybert wybert added the feature Features or general enhancements label Jun 8, 2023
@cpcloud cpcloud changed the title Geospatial Support For DuckDB feat(duckdb): add geospatial operations Jun 8, 2023
@cpcloud cpcloud added geospatial Geospatial related functionality duckdb The DuckDB backend labels Jun 8, 2023
@cpcloud
Copy link
Member

cpcloud commented Jun 8, 2023

@wybert Welcome! 👋🏻

Thanks for the issue. This has definitely been in the back of our minds for a bit 🙂

I think we were just waiting for someone to ask for it before doing the work!

I'm not sure this will make it into 6.0, and if not, then we should be able to get it in for the follow-up feature release (6.1).

@cpcloud cpcloud added this to the 6.1 milestone Jul 5, 2023
@cpcloud cpcloud modified the milestones: 6.1, 7.0 Aug 1, 2023
@NickCrews
Copy link
Contributor

Is this implemented? It's not on the list of dtypes. I also don't understand how to construct these values (casting from strings, directly from binary files).

@jcrist
Copy link
Member

jcrist commented Sep 8, 2023

Is this implemented? It's not on the list of dtypes.

Ibis has had geospatial support for a long time, this issue is for adding that support to duckdb. I'm not sure I fully understand your question, but the geospatial dtypes are in that list in the docs (e.g. LineString, Point, ...).

@NickCrews
Copy link
Contributor

e.g. LineString, Point

Ah, I didn't see those. I thought there was a singular GeoSpatialValue type based on the API list, and I didn't see that in the dtype list. I get it now.

this issue is for adding that support to duckdb

I get it now, TODO is just to add the translation stuff in backends/duckdb/registry.py (or similar). I thought those above dtypes and operations were added post-this-issue, and the docs and this issue just weren't updated. Sorry for the noise.

@cpcloud
Copy link
Member

cpcloud commented Sep 12, 2023

Update on this: we're interested in adding support for geospatial, but we have a sizable refactor of the duckdb backend underway (#6996) that needs to land (to avoid relegating @gforsyth to rebase hell) before we can make progress on any new feature work for the duckdb backend.

@ncclementi
Copy link
Contributor

/take

@cboettig
Copy link

cboettig commented Dec 9, 2023

🎉 are there updated docs showing this new awesomeness in action?

@cpcloud
Copy link
Member

cpcloud commented Dec 9, 2023

Not yet, but we have a blog post in PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duckdb The DuckDB backend feature Features or general enhancements geospatial Geospatial related functionality
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants