-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(tpcds): add queries 28-63 #9736
Conversation
efc26b1
to
42fe263
Compare
general question re: the baseline SQL queries: are there canonical (or non-canonical...?) sources that these are being drawn from? I imagine DuckDB has these somewhere in a benchmarking repo, but is that also the case with Clickhouse? Or did you perform the translation? |
|
The DuckDB ones are copied from their repo and then modified in ways that don't change the results (adding column names and casting to dates), to accommodate the more pedantic engines. Regarding ClickHouse, it looks like there's this https://github.com/Altinity/tpc-ds/tree/master/queries. It looks like they didn't rewrite anything heavily other than some truly atrocious formatting, and they are using some settings like
that might allow our code to work as well without having to special case clickhouse. I don't think there's a source of truth that works across all engines without alteration. |
oh, I'm sure that there isn't -- I was just wondering if we wanted to include links to upstream sources. Maybe also we can put some notes in a README in the various sql file collections with a brief overview of changes (like the one-sentence description you just gave about the DuckDB queries) |
Added a readme about the folly of TPC :) |
…ons in cross joins
…lready-explicitly-cast-to-date expressions
Re clickhouse settings, I should report the performance issue upstream, 200 MB of TPC-DS data shouldn't really be causing such a nutty performance problem. |
agreed. Also, on the subject of 200mb of data... if we bump up to Only 51 requires a higher threshold (searching now) |
hmm, I'm wrong, |
Nice, I will update the testing-data repo then! |
Do we want to merge this first and then I can handle the data updates in a follow-up? |
Sounds good -- I was waiting on the data updates, but those can definitely go in a follow-up |
oh lemme run the clouds before merging |
Adds TPC-DS queries 28-63. The commits adding the Ibis expressions are in batches of 10. It seemed no less annoying to do it that way than to create a separate PR for each batch of 10.