events.py test_Data data files missing

[jllanfranchi]

Unit test test_Data() fails due to missing data files. Since I'm in the process of removing test, data, and all but example settings files from the PISA "master" branch (i.e. cake) right now, don't add these in here, but I'll need to have access to them in order to add to e.g. a pisa_test directory I think I'll put on Wisconsin's servers that everyone can rsync when they want to run tests.

Preferably we get to the point that the pisa_test files are not proprietary at all (i.e. we don't mind sharing them publicly) but I'm not going to enforce that requirement right now, I'd much rather have working tests.

[ShiveshM]

The data files I use in that test function can also be found in the Wisconsin servers, so if you'd like I can change the paths so it'll work without needing to upload them ourselves to WIPAC.

[jllanfranchi]

What is the location of these files? (apologies if you told me already and i forgot...)

[ShiveshM]

oh, sorry I made a change to my $PISA_RESOURCES folder structure (PR #277).
For this test to pass you need a directory that's contained in $PISA_RESOURCES called LEESARD and then inside that folder you link to the following directory (at WIPAC):
/data/user/terliuk/PRD_extend_finalLevel
This is consistent with the configuration file leesard.cfg for the sample.py stage (in PR #277). If you want to use the greco.cfg configuration file in the sample.py stage then you also need to a folder in $PISA_RESOURCES called GRECO and then link it to this folder in WIPAC:
/data/ana/LE/NBI_nutau_appearance/current_pickle_files/current/new_style_files/
I screwed up the greco paths, so this will be updated in PR #278

[LeanderFischer]

Hm, so this still exists, but isn't used in the testing funciton 🤔 I wonder if we can just get rid of this then..

[thehrh]

I wouldn't remove the issue as long as the Data class still exists, since it should get a unit test in that case (740e061).

However, that class doesn't seem to be used by any other code than that intended unit test itself (https://github.com/search?q=repo%3Aicecube%2Fpisa+Data%28&type=code) - apart from an import (probably useless?) in

pisa/pisa/core/pipeline.py

Line 25 in 081606c

from pisa.core.events import Data

Maybe the better path forward would be to remove it completely (after some more research into its current and original use cases).

[thehrh]

For context: #364