Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map.py inconsistent handling of metrics / #264

Open
jllanfranchi opened this issue Dec 14, 2016 · 2 comments
Open

Map.py inconsistent handling of metrics / #264

jllanfranchi opened this issue Dec 14, 2016 · 2 comments
Labels
bug help wanted streamlining

Comments

@jllanfranchi
Copy link
Contributor

inconsistent treatment of metrics: args handled differently across chi2, llh, and metric* methods of Map.py
@philippeller
Copy link
Collaborator

Furthermore: in stats.py the checking of the input arrays and possible clipping of SMALL_POS numbers or inf is handled in every single function but should rather be done in one place (now is a lot of copy&paste code)

@jllanfranchi jllanfranchi added this to the 3.0.0 milestone Dec 16, 2016
@jllanfranchi jllanfranchi modified the milestones: 3.1, 3.0 Jun 30, 2017
@LeanderFischer LeanderFischer modified the milestones: 3.1, PISA 4.2 May 8, 2024
@LeanderFischer
Copy link
Collaborator

Ok, yeah, if this is still the case, then that should be tackled!

@thehrh thehrh removed this from the PISA 4.2 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted streamlining
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@philippeller @jllanfranchi @thehrh @LeanderFischer