Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2d histogram plotting codes #319

Open
jllanfranchi opened this issue Mar 30, 2017 · 1 comment
Open

Merge 2d histogram plotting codes #319

jllanfranchi opened this issue Mar 30, 2017 · 1 comment

Comments

@jllanfranchi
Copy link
Contributor

Plotting itself--at least for maps, if not other things--should be handled by utils/plotter.py. If that doesn't do something it should, then that functionality should be added to plotter.py and not duplicated in multiple modules.

Places where plotting seems duplicated:

  • utils/tests.py
  • analysis/profile_scan_postprocess.py
  • analysis/nmo_blindfits_postprocess.py
  • analysis/hypo_testing_postprocess.py (these plots seem somewhat orthogonal to histogram plots, but should double check that's the case)
  • core/map.py (we need a method that will simply plot a map or map set attached to these objects; but can be replaced by proper call(s) out to plotter.py module)
  • scripts/make_systematic_variation_plots.py (also possibly orthogonal to 2d hist plotting)
  • scripts/make_asymmetry_plots.py (might be unnecessary, as scripts/compare.py should handle this. Maybe need to add some command-line options to enable/disable plotting of non-asymmetry plots, etc. to the latter, though)
@LeanderFischer LeanderFischer added this to the PISA 4.2 milestone Apr 24, 2024
@LeanderFischer LeanderFischer added the Outdated Ancient issues that can be discarded label Apr 24, 2024
@LeanderFischer LeanderFischer removed this from the PISA 4.2 milestone Aug 22, 2024
@thehrh thehrh removed the Outdated Ancient issues that can be discarded label Sep 24, 2024
@thehrh
Copy link
Contributor

thehrh commented Sep 24, 2024

While many of the above modules/scripts are gone, there is still plotting duplication in utils/tests.py.
Let's consider removing that module altogether, since it contains "Functions to help compare and plot differences between PISA 2 and PISA 3 maps".

@thehrh thehrh self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants