Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Container representation #436

Open
philippeller opened this issue Jan 4, 2018 · 2 comments
Open

Virtual Container representation #436

philippeller opened this issue Jan 4, 2018 · 2 comments
Labels
enhancement

Comments

@philippeller
Copy link
Collaborator

In current PISA Pi, when containers are linked together, the first container in the list is chosen as a representative for all containers, without perfoming checks.....this is a bit sub-optimal
@philippeller philippeller mentioned this issue Jan 4, 2018
Merged
@LeanderFischer
Copy link
Collaborator

linking looks fine to me now

@LeanderFischer LeanderFischer closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2024
@thehrh
Copy link
Contributor

thehrh commented Aug 3, 2024 •
edited
Loading

As far as I can tell from

pisa/pisa/core/container.py

Line 194 in a752eaf

# should we check they're all the same?
, the issue still persists.

@thehrh thehrh reopened this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philippeller @thehrh @LeanderFischer