Fix for when a test run didn't produce any results

icnocop · Jan 28, 2019 · 8a00be1 · 8a00be1
1 parent 5caebef
commit 8a00be1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/ReleaseNotes.md b/ReleaseNotes.md
@@ -1,3 +1,7 @@
+# 1.0.1
+
+- [Fix] Makes sure not to end test runs that didn't send any results
+
 # 1.0.0
 
 - [Refactoring] Code quality improvements

diff --git a/src/AzurePipelines.TestLogger/LoggerQueue.cs b/src/AzurePipelines.TestLogger/LoggerQueue.cs
@@ -290,15 +290,18 @@ private async Task SendTestsCompleted(CancellationToken cancellationToken)
         {
             string completedDate = DateTime.UtcNow.ToString("yyyy-MM-ddTHH:mm:ss.FFFZ");
 
-            // Mark all parents as completed
-            string parentRequest = "[ " + string.Join(", ", Parents.Values.Select(x =>
-                $@"{{
+            // Mark all parents as completed (but only if we actually created a parent)
+            if (TestRunEndpoint != null)
+            {
+                string parentRequest = "[ " + string.Join(", ", Parents.Values.Select(x =>
+                    $@"{{
                     ""id"": {x.Id},
                     ""state"": ""Completed"",
                     ""startedDate"": ""{x.StartedDate.ToString("yyyy-MM-ddTHH:mm:ss.FFFZ")}"",
                     ""completedDate"": ""{completedDate}""
                 }}")) + " ]";
-            await _apiClient.SendAsync(new HttpMethod("PATCH"), TestRunEndpoint, "5.0-preview.5", parentRequest, cancellationToken).ConfigureAwait(false);
+                await _apiClient.SendAsync(new HttpMethod("PATCH"), TestRunEndpoint, "5.0-preview.5", parentRequest, cancellationToken).ConfigureAwait(false);
+            }
 
             // Mark the overall test run as completed
             string testRunRequest = $@"{{