Inconsistent new line behavior between properties with and without initializer.

[ElektroKill]

Input code

ICSharpCode.Decompiler.dll coming from the latest preview release (9.0-preview2)
Class: DecompileRun

Erroneous output

internal class DecompileRun
{
	public HashSet<string> DefinedSymbols { get; } = new HashSet<string>();


	public HashSet<string> Namespaces { get; } = new HashSet<string>();


	public CancellationToken CancellationToken { get; set; }

	public DecompilerSettings Settings { get; }

	public IDocumentationProvider DocumentationProvider { get; set; }

	public Dictionary<ITypeDefinition, RecordDecompiler> RecordDecompilers { get; } = new Dictionary<ITypeDefinition, RecordDecompiler>();


	public Dictionary<ITypeDefinition, bool> TypeHierarchyIsKnown { get; } = new Dictionary<ITypeDefinition, bool>();


	private Lazy<UsingScope> usingScope => new Lazy<UsingScope>(() => CreateUsingScope(Namespaces));

	public UsingScope UsingScope => usingScope.Value;

	public DecompileRun(DecompilerSettings settings)
	{
		Settings = settings ?? throw new ArgumentNullException("settings");
	}

	private UsingScope CreateUsingScope(HashSet<string> requiredNamespacesSuperset)
	{
		UsingScope usingScope = new UsingScope();
		foreach (string ns in requiredNamespacesSuperset)
		{
			string[] parts = ns.Split(new char[1] { '.' });
			AstType nsType = new SimpleType(parts[0]);
			for (int i = 1; i < parts.Length; i++)
			{
				nsType = new MemberType
				{
					Target = nsType,
					MemberName = parts[i]
				};
			}
			if (nsType.ToTypeReference(NameLookupMode.TypeInUsingDeclaration) is TypeOrNamespaceReference reference)
			{
				usingScope.Usings.Add(reference);
			}
		}
		return usingScope;
	}
}

The new lines between the properties is inconsistent and, in my opinion, is non ideal. From observation it seems that properties without an initializer get a single new line after them while properties which include an initializer get two new lines after them. This is most likely a bug in CSharpOutputVisitor.VisitPropertyDeclaration. It seems that replacing the call to Semicolon() here:

ILSpy/ICSharpCode.Decompiler/CSharp/OutputVisitor/CSharpOutputVisitor.cs

Line 2693 in 476e80b

Semicolon();

with WriteToken(Roles.Semicolon); fixes the issue. This means that the Semicolon() call unnecessarily inserts a new line in this case.

Details

• Reproduced using latest ILSpy 9.0-preview2 release.