Merged
Conversation
Collaborator
Contributor
Author
Web should work in one of the previous commits (37bad80) and we can narrow down and debug |
Collaborator
Contributor
Author
- flatten api file structure - refactor db to use latest drizzle ver - add web fallback for useWarmupBrowser
bjsilva1
reviewed
Sep 29, 2024
Collaborator
There was a problem hiding this comment.
Looks really good, going to make note of some of the TODOs left in the pr
TODO
Backend
- Add separate tests in
services.test.tsthat test upserts independently of database queries. - Add back the getMenu procedure with router tests
- Flush out the push notification system. We will start off by adding simple push notification tests and error handling.
- Design the system for push notifications to work with pinned items
- [Minor] Add tests for getRestaurantByDate
- Add test for daily and weekly server functions
- Event scraping tests using test HTML file
- Refactor weekly cron job into its own function? (up for debate)
Still need to test front end, will do once my docker decides to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes
Note
Above was already merged.
apiTest()?
not sure if we should be caching jwt in asyncstorage for web but thats what i did for right nowstopped caching jwt when on web.
Closes #457, Closes #447, Closes #449, Closes #437
demo
2024-05-30.22-22-15.mp4
ui for missing nutrition facts
generated diagram with
db:diagramscript