Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close AddYear Popup when click away #167

Closed
chenaaron3 opened this issue Feb 20, 2022 · 2 comments · Fixed by #419 or #406
Closed

Close AddYear Popup when click away #167

chenaaron3 opened this issue Feb 20, 2022 · 2 comments · Fixed by #419 or #406
Assignees
@Awesome-E
Labels
enhancement New feature or request peter's roadmap Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the
Milestone
Planner UI Improv...

Comments

@chenaaron3
Copy link
Contributor

chenaaron3 commented Feb 20, 2022 •
edited
Loading

Add year button, edit year button, mobile menu button will stay open even if the user clicks away. Make it so when user clicks away at anything else the menus will close.
screen-capture-8
@ethanwong16 ethanwong16 moved this to In Progress in PeterPortal Client Sep 9, 2022
@ethanwong16 ethanwong16 moved this from In Progress to Backlog in PeterPortal Client Oct 10, 2022
@ethanwong16 ethanwong16 added the Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the label Jan 28, 2023
@ethanwong16 ethanwong16 moved this from Backlog to In Progress in PeterPortal Client Feb 11, 2023
@ethanwong16 ethanwong16 moved this from In Progress to In Review in PeterPortal Client Apr 14, 2023
@js0mmer js0mmer assigned Awesome-E and unassigned AyushSat Jan 18, 2024
@js0mmer js0mmer moved this from In Review to Backlog in PeterPortal Client Jan 18, 2024
@js0mmer
Copy link
Member

js0mmer commented Jan 18, 2024

Use an OverlayTrigger.

@js0mmer js0mmer linked a pull request Jan 18, 2024 that will close this issue
add year popup goes away when clicking outside #280
Closed
@Awesome-E Awesome-E mentioned this issue Jan 24, 2024
Merged
2 tasks
@js0mmer js0mmer mentioned this issue Jan 25, 2024
Closed
@js0mmer js0mmer moved this from Backlog to In Progress in PeterPortal Client Jan 26, 2024
@js0mmer js0mmer added this to the Planner UI Improvements milestone Feb 8, 2024
@js0mmer
Copy link
Member

js0mmer commented Feb 15, 2024

Fixed by #406 and #419

@js0mmer js0mmer closed this as completed Feb 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in PeterPortal Client Feb 15, 2024
This was linked to pull requests Feb 15, 2024
Make add and edit year a modal #419
Merged
Clicking outside closes Quarter and Add Year Popovers #406
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Awesome-E Awesome-E

Labels
enhancement New feature or request peter's roadmap Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the
Projects
PeterPortal Client
Status: Done
Milestone
Planner UI Improvements
5 participants
@js0mmer @AyushSat @chenaaron3 @Awesome-E @ethanwong16