Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FeedbackModal.jsx #5

Open
stevem-zhou opened this issue Dec 12, 2023 · 1 comment · May be fixed by #14
Open

Refactor FeedbackModal.jsx #5

stevem-zhou opened this issue Dec 12, 2023 · 1 comment · May be fixed by #14
Assignees
@aryanm5

Comments

@stevem-zhou
Copy link
Collaborator

stevem-zhou commented Dec 12, 2023 •
edited by NwinNwin
Loading

Instructions

  • Refactor FeedbackModal.jsx under src/components/FeedbackModal

Acceptance Criteria

  • Refactor handleFeedback, utilize ApiUtils.js for API calls

  • Move any useState, Variables definition to the top of React Component

  • Move ternary operations → should be its own variable in a function (not inside the return statement)

  • Identify & Create functions for callback functions

Notes

Steps to Run React on your computer:

  • Clone the Frontend & Backend repos into 1 folder
  • npm install on both
  • npm start on both

How To Access FeedbackModal:

image

  • Run your frontend + backend localhost
  • Sign In to ZotNFound with UCI email
  • Create a test item
    • Press on List an Item
    • Follow the steps to post an item
    • In results bar, click on item and click resolve

Resources
@aryanm5
Copy link

aryanm5 commented Dec 20, 2023

I think the link for the refactor example for callback functions is wrong. It sends me to the ternary example.

@aryanm5 aryanm5 linked a pull request Dec 30, 2023 that will close this issue
Refactor ternary operations and callbacks in FeedbackModal.jsx #14
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryanm5 aryanm5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor ternary operations and callbacks in FeedbackModal.jsx icssc/zotnfound-frontend
2 participants
@aryanm5 @stevem-zhou