-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WGLC review of draft 11 #58
Comments
This has been reduced to an initial description in Section 1 and only very lightweight reference later on. |
No. This is not about "local attestation" this is about the relativity of what "remote" means. We added a reference to RATS Section 6 to make it clearer that very "close" things still might need conveyance protocols. |
Yes, that is the reason. A subtle difference is, for example, the difference between a nonce and an epoch marker including a nonce like structure. Another example would be the difference between an unsolicited push (as can be facilitated by time-based remote attestation) and a solicited push (as can be facilitated by streamed attestation). |
That was some awkward phrasing that has been improved since the last update. Thanks! |
Admittedly, not the best example. Moving the example to PSA TF-M. |
Thanks for considering the comments.
My thought here was that if the plan is to use the same models for Endorsements and Ref Values, it may make sense to put them in the same draft. If not, they may need a separate draft. |
Yes. Secure Channel (as in UCCS) + an extra mentioning of authentication (in an authentication section...) is now in. |
Thanks. Merged Evidence Protection into Attestation Evidence Authenticity. |
The Handle Section underwent a significant rewrite, which should also address this comment. |
The Reference Value Section underwent significant re-write and is now the Verifier Inputs Section, which should also address this comment. |
Same as above. |
The description includes your proposal already: |
There is now a more detailed subsection. I am trying to trace back where the "scrambling" part comes from and am leaning towards removing that paragraph as I am also uncertain what it brings to the table, tbh. Maybe during WGLC? |
Should already addressed by previous re-writes. Some minor redundancy remains for the sake of readability. |
Done! Thanks |
And it's gone. |
@muhammad-usama-sardar, could you review #63? |
Thanks for all the updates. There seems to be several other changes beyond PR 63 since my last review, which makes it difficult to judge whether all comments have been addressed. Unfortunately, this week is very busy for me. I have three presentations as well as meetings, and we are trying to get two new I-Ds before cut-off. Review seems unlikely before the cutoff but I will try my best. If I don't get to it, feel free to merge and I will go through the whole draft once again. To avoid another cycle, one general comment I have is that the figures with 3 parties are very hard to read. I am not sure if you fixed them already in your updates. Particularly, in some figures with 3 parties, it was unclear who is the originator of the message (I think this was in Sec. 7.1). Please consider clarifying that by using a consistent mechanism throughout the draft and writing it out explicitly for the readers. Also, please make sure all symbols used in figures are defined in the text. |
We can fix the remaining issues via a WGLC, I think. The Figures went through quite some polish, but I think the readability issue that your bring up is a new one. I'll submit and start the process and we can fix remaining issues along the way. |
General questions:
Specific questions/comments:
This is repeated at least 3 times in the draft. Can you justify this claim by presenting at least one example for each of those?
So your definition of "Local Attestation" is independent of where the Relying Party is?
With some interesting stuff out of scope, is it really the only motivation to write this draft? The draft is at such a high level of abstraction, I wonder if there are really any subtle discrepancies/inconsistencies this draft can help avoid. Can you give some examples of such subtle discrepancies?
What is it? Can you point me to a reference which uses "integral" in the sense of integrity?
MAC is not a signature!
Encryption by itself does not provide authentication.
This seems redundant. With "Attestation Evidence Authenticity", why is it required?
What is the exact difference between recentness and freshness? Can you give clear examples of cases when one of them holds while the other one does not? I think nonces provide all of them. Why do you specifically mention replay protection only?
Something seems to be missing here
This seems to say that Endorsements are also Reference Values: is this what you mean here? What is the exact difference between the Endorsements and Reference Values?
seems a misnomer as well as wrongly defined term. Isn't is something desired/requested by the Verifier?
Which certain types of relay attacks and how? Give more details.
Editorial
The text was updated successfully, but these errors were encountered: