CreateIfcWallAndWriteFile example produces warnings when validating the IFC Schema

[yacsha]

The CreateIfcWallAndWriteFile example was created using geometry_type=1 and the IFC4 schema an IfcPlusPlus 2.5.

IFC file from the CreateIfcWallAndWriteFile example, after changes were made to remove warnings 1 and 2: example2.5_1_2.zip

int main()
{
	shared_ptr<BuildingModel> ifc_model = shared_ptr<BuildingModel>(new BuildingModel());	
	ifc_model->getIfcSchemaVersionEnumCurrent() = BuildingModel::IFC4;
	LoadWallExample(ifc_model, true, true, 1);
	...
}

When using the IFC Schema validator at https://validate.buildingsmart.org/, for the IFC produced with the previous example, some warnings are obtained, some of which I have corrected and others I have not yet found a solution for, so I would appreciate your suggestions to correct them:

Warning 1:

The above warning was fixed by modifying the following part of the code:

shared_ptr<IfcCartesianPoint> createIfcCartesianPoint(double x, double y, std::vector<shared_ptr<BuildingEntity> >& vec_new_entities)
{
	shared_ptr<IfcCartesianPoint> pt(new IfcCartesianPoint());
	pt->m_Coordinates[0] = x;
	pt->m_Coordinates[1] = y;
	pt->m_Coordinates[2] = std::numeric_limits<double>::quiet_NaN(); // The z coordinate must be set to null so that IFCCARTESIANPOINT is reported with 2 coordinates instead of 3 coordinates (#17=IFCCARTESIANPOINT((5.,0.25,0.) )
	vec_new_entities.push_back(pt);
	return pt;
}

In the code above, the z coordinate must be set to null so that IFCCARTESIANPOINT is reported with 2 coordinates instead of 3. Example of an IfcCartesianPoint with 2 coordinates: #17=IFCCARTESIANPOINT((5.,0.25,0.). Another way would be to implement the default constructor for IfcCartesianPoint so that all coordinates are quiet_NaN by default, but I don't know if this option is viable. This eliminates Warning 1.

Warning 2:

The above warning was fixed by modifying the following part of the code:

// swept area as closed profile:
shared_ptr<IfcArbitraryClosedProfileDef> swept_area(new IfcArbitraryClosedProfileDef());
vec_new_entities.push_back(swept_area);
       
// The IfcProfileTypeEnum of type AREA is assigned, since it is mandatory to always define an IfcProfileTypeEnum for an IfcArbitraryClosedProfileDef
swept_area->m_ProfileType = shared_ptr<IfcProfileTypeEnum>(new IfcProfileTypeEnum());
swept_area->m_ProfileType->m_enum = IfcProfileTypeEnum::IfcProfileTypeEnumEnum::ENUM_AREA;

extruded_solid->m_SweptArea = swept_area;

Warnings I haven't been able to resolve yet:

[yacsha]

I've resolved all the IFC schema validations for the example. All that's left is to define some non-optional attributes and other details, which I'll explain below.

You can download the final example.ifc and main.cpp: example2.5_1_9.zip

It would be good to implement this in the main branch, because it took me a long time to figure out why IFCs generated with IfcPlusPlus didn't load correctly in some programs and did in others. Therefore, if the CreateIfcWallAndWriteFile example follows the standard schema, it will be easier for those new to IfcPlusPlus to understand how to generate IFCs with the correct schema.

I'd like to take this opportunity to thank the @ifcquery team for developing this great library and sharing it with the community.

Fix details:

• Added several non-optional attributes, detected by the schema validator.

• The geometry of swept_area->m_OuterCurve was also corrected, because in the IFC standard a closed curve for an IfcArbitraryClosedProfileDef is defined by adding the reference of the first point as the last point of IfcPolyline.

// these four points define the 2d polyline that is going to be extruded in z-direction:
shared_ptr<IfcCartesianPoint> ifc_point1 = createIfcCartesianPoint(0, 0, vec_new_entities);
poly_line->m_Points.push_back(ifc_point1);

shared_ptr<IfcCartesianPoint> ifc_point2 = createIfcCartesianPoint(wall_length, 0, vec_new_entities);
poly_line->m_Points.push_back(ifc_point2);

shared_ptr<IfcCartesianPoint> ifc_point3 = createIfcCartesianPoint(wall_length, wall_thickness, vec_new_entities);
poly_line->m_Points.push_back(ifc_point3);

shared_ptr<IfcCartesianPoint> ifc_point4 = createIfcCartesianPoint(0.0, wall_thickness, vec_new_entities);
poly_line->m_Points.push_back(ifc_point4);

poly_line->m_Points.push_back(ifc_point1); // <---- Added

• Added IfcApplication and IfcGeometricRepresentationSubContext as the IFC team recommends using them as industry best practices.

• Georeferencing of the IFC model was added, as it is also recommended as an industry best practice. For this purpose, IfcProjectedCRS and IfcMapConversion were added.

• In the end, the only thing left to resolve was the "Normative IFC Rules," which are resolved using standardized Psets.