Remove reminder's deletion from MedicationsController (#2057)

Author: brunoocasali

Diff for: app/controllers/medications_controller.rb

@@ -92,8 +92,7 @@ def update
   # DELETE /medications/1.json
   def destroy
     @medication.destroy
-    TakeMedicationReminder.where(medication_id: @medication.id).destroy_all
-    RefillReminder.where(medication_id: @medication.id).destroy_all
+
     redirect_to_path(medications_path)
   end
 

Diff for: app/models/medication.rb

@@ -50,8 +50,8 @@ class Medication < ApplicationRecord
   extend FriendlyId
   friendly_id :name
   belongs_to :user, foreign_key: :user_id
-  has_one :take_medication_reminder
-  has_one :refill_reminder
+  has_one :take_medication_reminder, dependent: :destroy
+  has_one :refill_reminder, dependent: :destroy
   accepts_nested_attributes_for :take_medication_reminder
   accepts_nested_attributes_for :refill_reminder
   validates :name, :dosage, :refill, :user_id, :total, :strength, :dosage_unit,

Diff for: spec/requests/medications_spec.rb

@@ -236,15 +236,15 @@ def put_update(medication_params)
       end
 
       context 'when medication has a daily reminder' do
-        let!(:medication) do
-          create(:medication, :with_daily_reminder, user: user)
-        end
+        let!(:medication) { create(:medication, user: user) }
+
+        before { medication.take_medication_reminder.update(active: true) }
 
         it 'destroys the medication' do
-          expect(TakeMedicationReminder.active.count).to eq(1)
-          expect { delete medication_path(medication) }
-            .to(change(Medication, :count).by(-1))
-          expect(TakeMedicationReminder.active.count).to eq(0)
+          expect {
+            delete medication_path(medication)
+          }.to change { Medication.count }.by(-1)
+            .and change { TakeMedicationReminder.count }.to(0)
         end
 
         it 'redirects to the medications path for html requests' do
@@ -259,15 +259,15 @@ def put_update(medication_params)
       end
 
       context 'when medication has a refill reminder' do
-        let!(:medication) do
-          create(:medication, :with_refill_reminder, user: user)
-        end
+        let!(:medication) { create(:medication, user: user) }
+
+        before { medication.refill_reminder.update(active: true) }
 
         it 'destroys the medication' do
-          expect(RefillReminder.active.count).to eq(1)
-          expect { delete medication_path(medication) }
-            .to(change(Medication, :count).by(-1))
-          expect(RefillReminder.active.count).to eq(0)
+          expect {
+            delete medication_path(medication)
+          }.to change { Medication.count }.by(-1)
+           .and change { RefillReminder.count }.to(0)
         end
 
         it 'redirects to the medications path for html requests' do