Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor possibility of boundary value problem #381

Open
h-bin-kim opened this issue Jan 29, 2024 · 0 comments
Open

Minor possibility of boundary value problem #381

h-bin-kim opened this issue Jan 29, 2024 · 0 comments

Comments

@h-bin-kim
Copy link

# yolox/tracker/byte_tracker.py, line 177~179
        ...
        remain_inds = scores > self.args.track_thresh
        inds_low = scores > 0.1
        # inds_high = scores < self.args.track_thresh  # original
        inds_high = scores <= self.args.track_thresh  # proposal
        ...

If the score is exactly equal to self.args.track_thresh, the instance will be ignored even though it should be handled appropriately.

While this scenario is highly improbable, implementing the fix would improve the code slightly.

>>> a = np.array([.4, .499999999, .5, .500000001, .6], dtype=float)
>>> a > .5
array([False, False, False,  True,  True])
>>> a < .5
array([ True,  True, False, False, False])
@h-bin-kim h-bin-kim changed the title Minor possibility of boundary value problems Minor possibility of boundary value problem Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant