Refactor Confirmation: replace custom FromStr implementation with strum

Author: haze518

configs/server.toml

@@ -464,7 +464,7 @@ message_expiry = "none"
 # Controls how the system waits for file write operations to complete.
 # Possible values:
 # - "wait": waits for the file operation to complete before proceeding.
-# - "nowait": proceeds without waiting for the file operation to finish, potentially increasing performance but at the cost of durability.
+# - "no_wait": proceeds without waiting for the file operation to finish, potentially increasing performance but at the cost of durability.
 server_confirmation = "wait"
 
 # Configures whether expired segments are archived (boolean) or just deleted without archiving.

integration/tests/streaming/segment.rs

@@ -264,7 +264,7 @@ async fn should_persist_and_load_segment_with_messages_with_nowait_confirmation(
         .await
         .unwrap();
     segment
-        .persist_messages(Some(Confirmation::Nowait))
+        .persist_messages(Some(Confirmation::NoWait))
         .await
         .unwrap();
     sleep(Duration::from_millis(200)).await;

sdk/src/confirmation.rs

@@ -1,32 +1,36 @@
-use std::{fmt, str::FromStr};
-
 use serde::{Deserialize, Serialize};
+use strum::{Display, EnumString};
 
-#[derive(Clone, Default, Deserialize, Serialize, Debug)]
+#[derive(Clone, Copy, Debug, Default, Display, Serialize, Deserialize, EnumString, PartialEq)]
+#[strum(serialize_all = "snake_case")]
 pub enum Confirmation {
     #[default]
     Wait,
-    Nowait,
+    NoWait,
 }
 
-impl FromStr for Confirmation {
-    type Err = String;
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use std::str::FromStr;
 
-    fn from_str(s: &str) -> Result<Self, Self::Err> {
-        match s.to_lowercase().as_str() {
-            "wait" => Ok(Confirmation::Wait),
-            "nowait" => Ok(Confirmation::Nowait),
-            _ => Err(format!("Invalid confirmation type: {}", s)),
-        }
+    #[test]
+    fn test_to_string() {
+        assert_eq!(Confirmation::Wait.to_string(), "wait");
+        assert_eq!(Confirmation::NoWait.to_string(), "no_wait");
+    }
+
+    #[test]
+    fn test_from_str() {
+        assert_eq!(Confirmation::from_str("wait").unwrap(), Confirmation::Wait);
+        assert_eq!(
+            Confirmation::from_str("no_wait").unwrap(),
+            Confirmation::NoWait
+        );
     }
-}
 
-impl fmt::Display for Confirmation {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        let s = match self {
-            Confirmation::Wait => "wait",
-            Confirmation::Nowait => "nowait",
-        };
-        write!(f, "{}", s)
+    #[test]
+    fn test_default() {
+        assert_eq!(Confirmation::default(), Confirmation::Wait);
     }
 }

server/src/streaming/segments/messages.rs

@@ -288,7 +288,7 @@ impl Segment {
         }
         let confirmation = match confirmation {
             Some(val) => val,
-            None => self.config.segment.server_confirmation.clone(),
+            None => self.config.segment.server_confirmation,
         };
         let saved_bytes = storage.save_batches(self, batch, confirmation).await?;
         storage.save_index(&self.index_path, index).await.with_error_context(|_| format!(

server/src/streaming/segments/storage.rs

@@ -267,7 +267,7 @@ impl SegmentStorage for FileSegmentStorage {
 
         let save_result = match confirmation {
             Confirmation::Wait => self.persister.append(&segment.log_path, &bytes).await,
-            Confirmation::Nowait => segment.persister_task.send(bytes.into()).await,
+            Confirmation::NoWait => segment.persister_task.send(bytes.into()).await,
         };
 
         save_result