New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample knots function first and last knots not correct #52

Open

zhengp0 opened this issue May 26, 2023 · 0 comments

Member

zhengp0 commented May 26, 2023

In https://github.com/ihmeuw-msca/mrtool/blob/main/src/mrtool/core/utils.py#L318-L319, the first and last knots set to be the very smallest and largest number in the list. This will lead to the knots not begin with 0 and end with 1 if the smallest bound is not 0 and largest bound is not 1. We should hard set to 0 and 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment