Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bathyCoverage name and definition #80

Closed
rmalyankar opened this issue Jan 29, 2024 · 3 comments
Closed

bathyCoverage name and definition #80

rmalyankar opened this issue Jan 29, 2024 · 3 comments
Labels
PS Product Specification

Comments

@rmalyankar
Copy link
Collaborator

          Attributes for DCF 9:
  1. bathyCoverage (Flag for nodes populated by interpolation) needs a new name, the registry already contains the concept Bathymetric Coverage (Extent to which an area has been surveyed using a systematic method of measuring the depth and is based on the combination of the survey pattern and the theoretical area of detection of the survey instrumentation).

Originally posted by @rmalyankar in #13 (comment)

@rmalyankar rmalyankar added the PS Product Specification label Jan 29, 2024
@giumas
Copy link
Collaborator

giumas commented May 26, 2024

A very similar issue has been identified in the ONSWG by @GlenRice-NOAA: "The one field in S-102 that concerns me is bathyCoverage. The definition seems reversed to me." (see OpenNavigationSurface/WorkingGroup#5 (comment))

The current note also seems to be inconsistent when to compared to the bathyCoverage description:

The attribute bathyCoverage is especially useful in side-scan surveys which are characterized by gaps in bathymetric observations with full coverage side-scan imagery (interpolated gapes between bathymetry coverage in this situation would show fullCoverage = True and bathyCoverage = False). If fullCoverage = False, bathyCoverage must also equal False, such as gaps between single beam echosounder data without correlating side-scan sonar coverage.

My feeling is that the original intent of bathyCoverage was not to be used as a "flag for nodes populated by interpolation". Furthermore, you can have 'sparse' data (e.g., leadline) and still decide to interpolate in the S102 grid across these soundings (as it is commonly done to draw contours in nautical charts).

So I believe that we have 2 options:

  • Modify the description of bathyCoverage to be something like "Flag for nodes populated by a measured depth".
  • Modify the name of bathyCoverage to be interpolatedCoverage (and modifying the note accordingly).

It is also an option to do both (i.e., having both bathyCoverage and interpolatedCoverage), thus having 3 boolean attributes for 3 statuses (bathymetric coverage, full coverage and interpolated without systematic data).

A final consideration is about naming inconsistency between 'bathyCoverage' and 'fullSeafloorCoverageAchieved'. Given that they are used in combination, the Achieved should be present or absent in both names.

@giumas
Copy link
Collaborator

giumas commented Jul 12, 2024

@RohdeBSH @anthonyklemm @rmalyankar, given that we already have fullSeafloorCoverageAchieved, then what about bathyCoverageAchieved ?

@giumas
Copy link
Collaborator

giumas commented Jul 12, 2024

The discussion will continue in #115

@giumas giumas closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PS Product Specification
Projects
None yet
Development

No branches or pull requests

2 participants