Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Upcoming live" and "Actually live" videos are caught in subsequent downloads [need to clearly explain errors, e.g. in "Tasks" view] #202

Open
deldesir opened this issue Jun 28, 2024 · 5 comments · May be fixed by #212
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@deldesir
Copy link
Collaborator

Regression / Known issue (introduced by PR #199)

"Upcoming live" and "Actually live" videos are caught in subsequent downloads as requested videos. They will remain as such until they are available, that means having a duration value.

image

Originally posted by @deldesir in #199 (comment)

@holta
Copy link
Member

holta commented Jun 28, 2024

Regression / Known issue (introduced by PR #199)

"Upcoming live" and "Actually live" videos are caught in subsequent downloads as requested videos. They will remain as such until they are available, that means having a duration value.

According to #199 (comment) itself:

A new PR should [address] this regression by automatically deleting these videos records from xklb-metadata.db

Thanks! Can this PR be pulled together relatively quickly?

Somewhat related:

@holta holta added bug Something isn't working question Further information is requested labels Jun 28, 2024
@deldesir
Copy link
Collaborator Author

I also think task messages should be adjusted according to #188 (comment)

@holta
Copy link
Member

holta commented Jun 28, 2024

I also think task messages should be adjusted according to #188 (comment)

"Tasks" view definitely sounds like the right place for this now. Please go ahead: (keep things as simple as possible!)

  • Tell people in plain English (1) what's really happening, (2) what they can do about it.
  • The English explanation can always be clarified (or made more vivid) later.

@holta
Copy link
Member

holta commented Jun 29, 2024

@deldesir is PR #194 fully adequate, as merged 9 days ago?

(Or does its code need to be slightly revised — if it too is somewhat related to explaining download mechanics of "ostensibly live" videos to users/operators ?)

@holta holta pinned this issue Jun 29, 2024
@deldesir
Copy link
Collaborator Author

deldesir commented Jul 1, 2024

The status messages should be more explicit to let the user know about the type of video being processed, I mean the live_status of the video.

@holta holta changed the title "Upcoming live" and "Actually live" videos are caught in subsequent downloads "Upcoming live" and "Actually live" videos are caught in subsequent downloads [need to clearly explain errors, e.g. in "Tasks" view] Jul 6, 2024
@holta holta unpinned this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
2 participants