Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect pieces for SSP 2024/ScenarioMIP workflows #234

Open
khaeru opened this issue Sep 26, 2024 · 4 comments
Open

Collect pieces for SSP 2024/ScenarioMIP workflows #234

khaeru opened this issue Sep 26, 2024 · 4 comments
Labels
p:SSP-2024 2024 SSP updates and ScenarioMIP

Comments

@khaeru
Copy link
Member

khaeru commented Sep 26, 2024

As discussed at today's MESSAGE team meeting.

We want to, at some point, bring together all the improvements and new code used in the SSP/ScenarioMIP workflows. This issue is to:

  1. Identify what and where those pieces are, how they are used (in what order), etc.
  2. Decide where they should eventually ‘land’ within message-ix-models or other repos.
  3. Track as they are associated with PRs, either:

Pieces

General/other

Direct air capture (DAC)

Materials

Techno-economic parameters (@measrainsey)

Water/nexus

Things to do

  • Leave a comment below or edit the description to add further details.
    • Please try not to add so much that the overall list is not readable; rather add full description at the respective issue/PR, and put a ~1-sentence summary.
    • These can include future plans/intentions for next steps.
  • Open a draft PR for any branch with associated code.
    • This PR may not ever be merged, but makes it much easier to understand and communicate about the changes on a branch.
  • or, Add to #235.
  • Ask @glatterf42 @khaeru if unsure about what to do.
@khaeru khaeru added the p:SSP-2024 2024 SSP updates and ScenarioMIP label Sep 26, 2024
khaeru added a commit that referenced this issue Sep 26, 2024
khaeru added a commit that referenced this issue Sep 26, 2024
@adrivinca
Copy link
Contributor

Thanks for this, I started a branch wat_SSP_upd1 that takes a bit from the older water_SSP_update (soon obsolete) but that is meant to be for few incremental fixes, including tests when possible

@khaeru
Copy link
Member Author

khaeru commented Sep 27, 2024

@adrivinca I updated the description to replace “Another small change by @adrivinca that will be included in a small PR” with #236 —assuming that's the thing you referred to on Thursday. Please correct if I'm wrong there.

@measrainsey
Copy link
Contributor

measrainsey commented Oct 2, 2024

Hi! Thank you for documenting this process.

I have a question: I have a few scripts (that are currently on a personal repo) that have my workflow of the modifications I made to certain scenarios for the ScenarioMIP submission. Nothing complicated, just small changes to diffusion constraints and share constraints in the transport, residential + commercial, and industry sectors.
I imagine it would be best to migrate these scripts to a team-accessible location.

Where would be the best place to move my scripts over? Should they be housed here on message-ix-models (for example, in message_ix_models.project.ssp)?

@khaeru
Copy link
Member Author

khaeru commented Oct 2, 2024

@measrainsey yes, that would be wonderful, thank you!

I would suggest:

  1. Create a branch like ssp-dev/mm or similar.
  2. Create a directory like message_ix_models/project/ssp/script/.
  3. Commit files (warts and all, no clean-up needed) into that directory.
  4. Open a draft PR into the branch ssp-dev associated with Collect pieces for SSP 2024/ScenarioMIP #235.

Once others to do the same, we can check for discrepancies, and figure out an appropriate way to bring the pieces together.

khaeru added a commit that referenced this issue Oct 2, 2024
khaeru added a commit that referenced this issue Oct 24, 2024
macflo8 pushed a commit that referenced this issue Nov 11, 2024
khaeru added a commit that referenced this issue Nov 14, 2024
khaeru added a commit that referenced this issue Nov 21, 2024
khaeru added a commit that referenced this issue Nov 26, 2024
khaeru added a commit that referenced this issue Dec 2, 2024
khaeru added a commit that referenced this issue Dec 3, 2024
khaeru added a commit that referenced this issue Dec 4, 2024
khaeru added a commit that referenced this issue Dec 4, 2024
macflo8 pushed a commit that referenced this issue Dec 5, 2024
macflo8 pushed a commit that referenced this issue Dec 6, 2024
khaeru added a commit that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:SSP-2024 2024 SSP updates and ScenarioMIP
Projects
None yet
Development

No branches or pull requests

3 participants