-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't change color for built-in subtitles #4965
Comments
Did not reproduce for me. I downloaded the YouTube video Youtube Auto Generated Subtitles - Tutorial using yt-dlp passing the options shown here:
While playing the video I clicked on There are many different types of subtitles. Have a look at this list of subtitle formats from Wikipedia. We need to know what kind is in the video files you are having trouble with. If you can post a small video sample I can reproduce the problem and tell you want is going on. If it is too big for GitHub you could shorten it using ffmpeg or post it to THE NULL POINTER, https://0x0.st/ If it is not possible to provide a video sample that exhibits the problem, start playing the video and follow these instructions:
|
Thanks for your timely response. As your comment suggested, I've tested the youtube vid you posted and the color and font of its subtitle could be changed correctly. I've uploaded a small video clip that could reproduce the issue raised on my computer: On my computer, it shows as below: Please let me know if you need any other information to pin point the issue. Thanks again for your support! |
Thank you for posting the sample. The behavior reproduced for me. Many subtitle formats are "text" based. The subtitle stream contains values that are codes for letters and numbers and can be edited by TextEdit. To display such subtitles a player must form pictures of the subtitles and then place them into a frame of the video. As the player is converting the subtitles from text to a picture it can control the color and font to use for the conversion. In the screenshot of the To be able to alter the display of subtitles in pgs format there are two choices that I know of. Find and download subtitles in Advanced SubStation Alpha (.ass) or SubRip (.srt) format from a subtitles site such as Open Subtitles or use a subtitle converter that uses OCR to convert the image based subtitles into text based ones. Searching GitHub I found MKV-Subtitle-Converter which uses Tesseract OCR. I've never tried using MKV-Subtitle-Converter so I can't say anything more about this program. Possibly IINA could detect that the current subtitle format is image based and disable the subtitle controls that have no effect on such subtitles. |
Thanks for your detailed response! I now understand why the color could not be changed, but as you said, indeed it will send a clearer message for user if IINA could disable the subtitle controls for this kind of format. I would definitely check the solutions you pointed out for me afterwards. Thanks again for your time! |
System and IINA version:
Expected behavior:
I should be able to change subtitle color for built in subtitles in both "..."->Subtitle quick setting, or in IINA->Settings->Subtitle->Text Subtitles
Actual behavior:
The subtitle color changing works for subtitles in separate files like .srt for me, but for built in subtitles that's packed in .mkv file, I cannot change the subtitle color. The behavior is as below:
In "..."->Subtitle quick setting, I cannot save the color I choose for subtitles (as the screencap below). There is no button like "OK" or "Done" that I could press after selecting a color, and the color is not saved after I press "x" to close the colors window.
![image](https://private-user-images.githubusercontent.com/92386577/335268572-5cd6e821-d393-4013-9d19-6f7d5f1ceadc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1NzE4ODUsIm5iZiI6MTcxOTU3MTU4NSwicGF0aCI6Ii85MjM4NjU3Ny8zMzUyNjg1NzItNWNkNmU4MjEtZDM5My00MDEzLTlkMTktNmY3ZDVmMWNlYWRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDEwNDYyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiYTUzOGYyODE0MzA2Y2VjNGQ2YzA4ODMxMTg5ODk2YTZhZDkyMDVmYTI5ODVkZThmY2U3MWY4NzI1YzY3NWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.tC54ACPtc1q90xBQAw7dw2qG0SHh6tIZtkqCzEkCuzM)
In IINA->Settings->Subtitle->Text Subtitles, although I can save the color I choose for subtitles, it seems to have no effect. As the screencap below, the actual subtitle is not changing color as I chose, and it is inconsistent with the subtitle color in the quick setting menu.
![image](https://private-user-images.githubusercontent.com/92386577/335272479-3c9f376b-a77a-492b-a5d7-f4553213e0f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk1NzE4ODUsIm5iZiI6MTcxOTU3MTU4NSwicGF0aCI6Ii85MjM4NjU3Ny8zMzUyNzI0NzktM2M5ZjM3NmItYTc3YS00OTJiLWE1ZDctZjQ1NTMyMTNlMGYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI4VDEwNDYyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThlN2VhMmZiM2VmMTlkNGYwZWFiZDkwNzk1ZjA3MjYwOWExMmIxZDNkYzRkM2EyMGMxYzJjYzgzY2VhOWNlZjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.aMA0zuLVVdJxdjPL1c-95PWXiJa5IgAJrTbb47VAN1s)
Crash report:
mpv log:
Steps to reproduce:
All of the tested .mkv files with packed subtitles could reproduce the issue on my computer.
How often does this happen?
Always.
The text was updated successfully, but these errors were encountered: