default-intel-detail: action doesn't correspond to description

[johnd0e]

Use the portal level detail levels from the standard intel site. By default, IITC shows less detail when zoomed out, as this is enough for general use, is more friendly to the niantic servers, and loads much faster. This plugin restores the default zoom level to portal level mapping. Note: using this plugin causes a larger number of requests to the intel server, and at high resolutions can cause excessive requests to be made (yes: the default intel site also has this problem!), so it is not recommended except for low resolution screens.

Here is all the code:

ingress-intel-total-conversion/plugins/default-intel-detail.user.js

Lines 29 to 35 in f904527

	window.plugin.defaultIntelDetail.setup = function() {
	// NOTE: the logic required is closely tied to the IITC+stock map detail level code - so the logic is moved there now
	// and just enabled by this flag
	window.CONFIG_ZOOM_DEFAULT_DETAIL_LEVEL=true;
	};

ingress-intel-total-conversion/code/map_data_calc_tools.js

Lines 129 to 151 in f904527

	if (!window.CONFIG_ZOOM_DEFAULT_DETAIL_LEVEL) {
	// to improve the cacheing performance, we try and limit the number of zoom levels we retrieve data for
	// to avoid impacting server load, we keep ourselves restricted to a zoom level with the sane numbre
	// of tilesPerEdge and portal levels visible
	var origTileParams = getMapZoomTileParameters(zoom);
	while (zoom > MIN_ZOOM) {
	var newTileParams = getMapZoomTileParameters(zoom-1);
	if ( newTileParams.tilesPerEdge != origTileParams.tilesPerEdge
	|| newTileParams.hasPortals != origTileParams.hasPortals
	|| newTileParams.level*newTileParams.hasPortals != origTileParams.level*origTileParams.hasPortals // multiply by 'hasPortals' bool - so comparison does not matter when no portals available
	) {
	// switching to zoom-1 would result in a different detail level - so we abort changing things
	break;
	} else {
	// changing to zoom = zoom-1 results in identical tile parameters - so we can safely step back
	// with no increase in either server load or number of requests
	zoom = zoom-1;
	}
	}

As I can understand this part of getDataZoomForMapZoom, the optimization does not affect details level, and that it exact intent of the getDataZoomForMapZoom.
So (contrary to the description) option window.CONFIG_ZOOM_DEFAULT_DETAIL_LEVEL is unable to increase details level, and there is no reason to use it (even for lo-res screens).