From 7c6aac42de2803ecd3fb5dbd5dfb4627e60b4824 Mon Sep 17 00:00:00 2001 From: Stefan Topfstedt Date: Mon, 1 Jul 2024 14:39:13 -0700 Subject: [PATCH] improve user context filter descriptions and add translations where missing. --- .../components/dashboard/user-context-filter.hbs | 8 ++++---- packages/ilios-common/translations/en-us.yaml | 4 ++-- packages/ilios-common/translations/es.yaml | 8 ++++---- packages/ilios-common/translations/fr.yaml | 8 ++++---- .../components/dashboard/user-context-filter-test.js | 11 ++++------- 5 files changed, 18 insertions(+), 21 deletions(-) diff --git a/packages/ilios-common/addon/components/dashboard/user-context-filter.hbs b/packages/ilios-common/addon/components/dashboard/user-context-filter.hbs index 8dde2a812f..c901581b64 100644 --- a/packages/ilios-common/addon/components/dashboard/user-context-filter.hbs +++ b/packages/ilios-common/addon/components/dashboard/user-context-filter.hbs @@ -12,12 +12,12 @@ title={{ if (eq @userContext "instructor") (t "general.showAllMyActivities") - (t "general.showOnlyMyInstructingActivities") + (t "general.showOnlyMyInstructorActivities") }} aria-description={{ if (eq @userContext "instructor") (t "general.showAllMyActivities") - (t "general.showOnlyMyInstructingActivities") + (t "general.showOnlyMyInstructorActivities") }} data-test-instructing-label @@ -37,12 +37,12 @@ title={{ if (eq @userContext "learner") (t "general.showAllMyActivities") - (t "general.showOnlyMyLearningActivities") + (t "general.showOnlyMyLearnerActivities") }} aria-description={{ if (eq @userContext "learner") (t "general.showAllMyActivities") - (t "general.showOnlyMyLearningActivities") + (t "general.showOnlyMyLearnerActivities") }} data-test-learning-label > diff --git a/packages/ilios-common/translations/en-us.yaml b/packages/ilios-common/translations/en-us.yaml index 11f21c86b2..e6e7e06254 100644 --- a/packages/ilios-common/translations/en-us.yaml +++ b/packages/ilios-common/translations/en-us.yaml @@ -323,8 +323,8 @@ general: showNotesToStudents: Show Notes to Students showObjectives: Show objectives showOnlyMyAdminActivities: Show only my admin activities - showOnlyMyInstructingActivities: Show only my instructing activities - showOnlyMyLearningActivities: Show only my learning activities + showOnlyMyInstructorActivities: Show only my instructor activities + showOnlyMyLearnerActivities: Show only my learner activities showSessionEvents: "Show all other ''{sessionTitle}'' events" showSessionMaterials: Show session materials smallGroupMessage: 'Please select at least one learner group to attach to your small group offering. If you wish to schedule this offering without groups, please select the "offering" button above.' diff --git a/packages/ilios-common/translations/es.yaml b/packages/ilios-common/translations/es.yaml index 998d602cbb..3bca23723f 100644 --- a/packages/ilios-common/translations/es.yaml +++ b/packages/ilios-common/translations/es.yaml @@ -313,7 +313,7 @@ general: sessionType: Tipo de Sesión sessionTypes: Tipos de Sesiones sessionTypesFor: "Tipos de Sesiones para {subject}" - showAllMyActivities: Show all my activities + showAllMyActivities: Mostrar todas mis actividades showCalendar: Muestre Calendario showCourseMaterials: Mostrar materiales del curso showFilters: Enseñe Filtros @@ -327,9 +327,9 @@ general: smallGroupMessage: 'Por favor seleccione al menos un grupo de alumnos para adjuntar a su ofrecimiento de grupos pequeños. Si usted desea programar este ofrecimiento sin grupos, favor de seleccionar el botón de "ofrecimiento" de arriba.' smallGroups: Grupos Pequeños sortMaterials: Clasificar los materiales - showOnlyMyAdminActivities: Show only my admin activities - showOnlyMyInstructingActivities: Show only my instructing activities - showOnlyMyLearningActivities: Show only my learning activities + showOnlyMyAdminActivities: Mostrar solo mis actividades de administrador + showOnlyMyInstructorActivities: Mostrar solo las actividades de mi instructor + showOnlyMyLearnerActivities: Mostrar solo mis actividades de aprendizaje sortObjectives: Clasificar los objetivos specialAttireIs_Required_: "Se ''require'' vestimenta especial" specialAttireRequired: Vestimenta Especial Requerido diff --git a/packages/ilios-common/translations/fr.yaml b/packages/ilios-common/translations/fr.yaml index d2c9098db5..c62456a641 100644 --- a/packages/ilios-common/translations/fr.yaml +++ b/packages/ilios-common/translations/fr.yaml @@ -313,7 +313,7 @@ general: sessionType: Type de Séance sessionTypes: Types de Séance sessionTypesFor: "Types de Séance par {subject}" - showAllMyActivities: Show all my activities + showAllMyActivities: Afficher toutes mes activités showCalendar: Afficher Calendrier showCourseMaterials: Afficher les supports de cours showFilters: Montrez les Filtres @@ -322,9 +322,9 @@ general: showMore: Afficher plus showNotesToStudents: Afficher notes aux étudiantes showObjectives: Afficher les objectifs - showOnlyMyAdminActivities: Show only my admin activities - showOnlyMyInstructingActivities: Show only my instructing activities - showOnlyMyLearningActivities: Show only my learning activities + showOnlyMyAdminActivities: Afficher uniquement mes activités d'administrateur + showOnlyMyInstructorActivities: Afficher uniquement mes activités d'instructeur + showOnlyMyLearnerActivities: Afficher uniquement mes activités d'apprenant showSessionEvents: "Montrez tous les autres ''{sessionTitle}'' événements" showSessionMaterials: Afficher les supports de session smallGroupMessage: 'S''il vous plaît choisir au moins un groupe d''apprenants à joindre à votre offrande de "small groups". Si vous souhaitez programmer cette offrande sans groupes, s''il vous plaît choisir le bouton "offre" au-dessus.' diff --git a/packages/test-app/tests/integration/components/dashboard/user-context-filter-test.js b/packages/test-app/tests/integration/components/dashboard/user-context-filter-test.js index 9b03c0efb5..e106c54692 100644 --- a/packages/test-app/tests/integration/components/dashboard/user-context-filter-test.js +++ b/packages/test-app/tests/integration/components/dashboard/user-context-filter-test.js @@ -12,16 +12,13 @@ module('Integration | Component | dashboard/user-context-filter', function (hook test('it renders', async function (assert) { await render(hbs``); assert.strictEqual(component.instructing.label, 'Instructing'); - assert.strictEqual( - component.instructing.ariaDescription, - 'Show only my instructing activities', - ); - assert.strictEqual(component.instructing.title, 'Show only my instructing activities'); + assert.strictEqual(component.instructing.ariaDescription, 'Show only my instructor activities'); + assert.strictEqual(component.instructing.title, 'Show only my instructor activities'); assert.notOk(component.instructing.isChecked); assert.ok(component.instructing.isActive); assert.strictEqual(component.learning.label, 'Learning'); - assert.strictEqual(component.learning.ariaDescription, 'Show only my learning activities'); - assert.strictEqual(component.learning.title, 'Show only my learning activities'); + assert.strictEqual(component.learning.ariaDescription, 'Show only my learner activities'); + assert.strictEqual(component.learning.title, 'Show only my learner activities'); assert.notOk(component.learning.isChecked); assert.ok(component.learning.isActive); assert.strictEqual(component.admin.label, 'Admin');