From 9721bdd4cda8f1af67e336e2099f8d933e8f705d Mon Sep 17 00:00:00 2001 From: Jonathan Johnson Date: Tue, 16 Jul 2024 21:48:50 -0700 Subject: [PATCH] Clear Glimmer Parser Deprecations We need to filter out literals here and only deal with the PathExpression types as only they have the `original` property. Calling `.original` on any other type is deprecated (plus it doesn't work). --- packages/ilios-common/lib/get-errors-for-transform.js | 2 +- packages/ilios-common/lib/has-error-for-transform.js | 2 +- packages/ilios-common/lib/set-transform.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/ilios-common/lib/get-errors-for-transform.js b/packages/ilios-common/lib/get-errors-for-transform.js index 7cd4a15135..aea6c54cb1 100644 --- a/packages/ilios-common/lib/get-errors-for-transform.js +++ b/packages/ilios-common/lib/get-errors-for-transform.js @@ -43,7 +43,7 @@ module.exports = class GetErrorsForTransform { } transformNode(node) { - if (node.path.original === 'get-errors-for') { + if (node.path.type === 'PathExpression' && node.path.original === 'get-errors-for') { if (!node.params[0] || node.params[0].type !== 'PathExpression') { throw new Error( 'the (get-errors-for) helper requires a path to be passed in as its first parameter, received: ' + diff --git a/packages/ilios-common/lib/has-error-for-transform.js b/packages/ilios-common/lib/has-error-for-transform.js index 40368f2a34..336b809dd9 100644 --- a/packages/ilios-common/lib/has-error-for-transform.js +++ b/packages/ilios-common/lib/has-error-for-transform.js @@ -43,7 +43,7 @@ module.exports = class HasErrorForTransform { } transformNode(node) { - if (node.path.original === 'has-error-for') { + if (node.path.type === 'PathExpression' && node.path.original === 'has-error-for') { if (!node.params[0] || node.params[0].type !== 'PathExpression') { throw new Error( 'the (has-error-for) helper requires a path to be passed in as its first parameter, received: ' + diff --git a/packages/ilios-common/lib/set-transform.js b/packages/ilios-common/lib/set-transform.js index e1c4825d50..de07159fdc 100644 --- a/packages/ilios-common/lib/set-transform.js +++ b/packages/ilios-common/lib/set-transform.js @@ -45,7 +45,7 @@ module.exports = class SetTransform { } transformNode(node) { - if (node.path.original === 'set') { + if (node.path.type === 'PathExpression' && node.path.original === 'set') { if (!node.params[0] || node.params[0].type !== 'PathExpression') { throw new Error( 'the (set) helper requires a path to be passed in as its first parameter, received: ' +