From ab041ac60c9da8fef00b4555be9791d457a208ad Mon Sep 17 00:00:00 2001 From: Jonathan Johnson Date: Wed, 24 Jul 2024 22:15:35 -0700 Subject: [PATCH] Add Timeouts for Deploys These are defaulting to 6 hours, when they hang we don't get a failure message. Adding a step timeout should fail so we get a message, and then adding a job timeout just to save the world a bit if we run long. --- .github/workflows/deploy-pr.yml | 2 ++ .github/workflows/deploy-production.yml | 2 ++ .github/workflows/deploy-staging.yml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/.github/workflows/deploy-pr.yml b/.github/workflows/deploy-pr.yml index c935191172..c78cc97ede 100644 --- a/.github/workflows/deploy-pr.yml +++ b/.github/workflows/deploy-pr.yml @@ -11,6 +11,7 @@ jobs: deploy: name: Deploy PR Preview runs-on: ubuntu-latest + timeout-minutes: 60 if: contains(github.event.pull_request.labels.*.name, 'safe to deploy') steps: - uses: actions/checkout@v4 @@ -25,6 +26,7 @@ jobs: cache: pnpm - run: pnpm install - name: Ember CLI Deploy + timeout-minutes: 30 run: pnpm --filter frontend exec ember deploy pr-preview env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} diff --git a/.github/workflows/deploy-production.yml b/.github/workflows/deploy-production.yml index 6f541ce002..042fd25a47 100644 --- a/.github/workflows/deploy-production.yml +++ b/.github/workflows/deploy-production.yml @@ -14,6 +14,7 @@ jobs: deploy: name: Deploy and Create Sentry Release runs-on: ubuntu-latest + timeout-minutes: 60 steps: - uses: actions/checkout@v4 - uses: pnpm/action-setup@v4 @@ -25,6 +26,7 @@ jobs: cache: pnpm - run: pnpm install - name: Ember CLI Deploy + timeout-minutes: 30 run: pnpm -r run --parallel deploy:production env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml index 1ee4dc709b..d52ce4721e 100644 --- a/.github/workflows/deploy-staging.yml +++ b/.github/workflows/deploy-staging.yml @@ -12,6 +12,7 @@ jobs: deploy: name: Deploy runs-on: ubuntu-latest + timeout-minutes: 60 steps: - uses: actions/checkout@v4 - uses: pnpm/action-setup@v4 @@ -23,6 +24,7 @@ jobs: cache: pnpm - run: pnpm install - name: Ember CLI Deploy + timeout-minutes: 30 run: pnpm -r run --parallel deploy:staging env: AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}