Add SettingsManager for per-agent model configuration Implement project-level settings loading from .hatchbox/settings.json with support for per-agent model overrides. Integrate settings into IgniteCommand to merge agent configurations before passing to Claude CLI. Includes comprehensive test coverage for settings loading, validation, and model precedence. Fixes #93

Author: acreeger

src/commands/ignite.test.ts

@@ -1112,4 +1112,218 @@ describe('IgniteCommand', () => {
 			}
 		})
 	})
+
+	describe('settings integration', () => {
+		it('should load settings and pass to AgentManager', async () => {
+			const launchClaudeSpy = vi.spyOn(claudeUtils, 'launchClaude').mockResolvedValue(undefined)
+			const getRepoInfoSpy = vi.spyOn(githubUtils, 'getRepoInfo').mockResolvedValue({
+				owner: 'testowner',
+				name: 'testrepo',
+			})
+
+			const mockSettings = {
+				agents: {
+					'test-agent': {
+						model: 'haiku',
+					},
+				},
+			}
+
+			const mockSettingsManager = {
+				loadSettings: vi.fn().mockResolvedValue(mockSettings),
+			}
+
+			const mockAgentManager = {
+				loadAgents: vi.fn().mockResolvedValue({
+					'test-agent': {
+						description: 'Test agent',
+						prompt: 'Test prompt',
+						tools: ['Read'],
+						model: 'haiku', // Should be overridden
+					},
+				}),
+				formatForCli: vi.fn((agents) => agents),
+			}
+
+			const originalCwd = process.cwd
+			process.cwd = vi.fn().mockReturnValue('/path/to/feat/issue-123-test')
+
+			const commandWithSettings = new IgniteCommand(
+				mockTemplateManager,
+				mockGitWorktreeManager,
+				mockAgentManager as never,
+				mockSettingsManager as never,
+			)
+
+			try {
+				await commandWithSettings.execute()
+
+				// Verify settings were loaded
+				expect(mockSettingsManager.loadSettings).toHaveBeenCalled()
+
+				// Verify settings were passed to loadAgents
+				expect(mockAgentManager.loadAgents).toHaveBeenCalledWith(mockSettings)
+			} finally {
+				process.cwd = originalCwd
+				launchClaudeSpy.mockRestore()
+				getRepoInfoSpy.mockRestore()
+			}
+		})
+
+		it('should handle missing settings gracefully and continue', async () => {
+			const launchClaudeSpy = vi.spyOn(claudeUtils, 'launchClaude').mockResolvedValue(undefined)
+			const getRepoInfoSpy = vi.spyOn(githubUtils, 'getRepoInfo').mockResolvedValue({
+				owner: 'testowner',
+				name: 'testrepo',
+			})
+
+			const mockSettingsManager = {
+				loadSettings: vi.fn().mockResolvedValue({}), // Empty settings
+			}
+
+			const mockAgentManager = {
+				loadAgents: vi.fn().mockResolvedValue({
+					'test-agent': {
+						description: 'Test agent',
+						prompt: 'Test prompt',
+						tools: ['Read'],
+						model: 'sonnet',
+					},
+				}),
+				formatForCli: vi.fn((agents) => agents),
+			}
+
+			const originalCwd = process.cwd
+			process.cwd = vi.fn().mockReturnValue('/path/to/feat/issue-123-test')
+
+			const commandWithSettings = new IgniteCommand(
+				mockTemplateManager,
+				mockGitWorktreeManager,
+				mockAgentManager as never,
+				mockSettingsManager as never,
+			)
+
+			try {
+				await commandWithSettings.execute()
+
+				// Should still execute successfully
+				expect(mockSettingsManager.loadSettings).toHaveBeenCalled()
+				expect(mockAgentManager.loadAgents).toHaveBeenCalledWith({})
+				expect(launchClaudeSpy).toHaveBeenCalled()
+			} finally {
+				process.cwd = originalCwd
+				launchClaudeSpy.mockRestore()
+				getRepoInfoSpy.mockRestore()
+			}
+		})
+
+		it('should handle settings loading errors without crashing', async () => {
+			const launchClaudeSpy = vi.spyOn(claudeUtils, 'launchClaude').mockResolvedValue(undefined)
+			const getRepoInfoSpy = vi.spyOn(githubUtils, 'getRepoInfo').mockResolvedValue({
+				owner: 'testowner',
+				name: 'testrepo',
+			})
+
+			const mockSettingsManager = {
+				loadSettings: vi.fn().mockRejectedValue(new Error('Failed to load settings')),
+			}
+
+			const mockAgentManager = {
+				loadAgents: vi.fn().mockResolvedValue({
+					'test-agent': {
+						description: 'Test agent',
+						prompt: 'Test prompt',
+						tools: ['Read'],
+						model: 'sonnet',
+					},
+				}),
+				formatForCli: vi.fn((agents) => agents),
+			}
+
+			const originalCwd = process.cwd
+			process.cwd = vi.fn().mockReturnValue('/path/to/feat/issue-123-test')
+
+			const commandWithSettings = new IgniteCommand(
+				mockTemplateManager,
+				mockGitWorktreeManager,
+				mockAgentManager as never,
+				mockSettingsManager as never,
+			)
+
+			try {
+				// Should not throw - execution continues without settings
+				await commandWithSettings.execute()
+
+				expect(mockSettingsManager.loadSettings).toHaveBeenCalled()
+				// loadAgents should be called without settings (undefined)
+				expect(mockAgentManager.loadAgents).toHaveBeenCalled()
+				expect(launchClaudeSpy).toHaveBeenCalled()
+			} finally {
+				process.cwd = originalCwd
+				launchClaudeSpy.mockRestore()
+				getRepoInfoSpy.mockRestore()
+			}
+		})
+
+		it('should pass merged agent configs to Claude CLI', async () => {
+			const launchClaudeSpy = vi.spyOn(claudeUtils, 'launchClaude').mockResolvedValue(undefined)
+			const getRepoInfoSpy = vi.spyOn(githubUtils, 'getRepoInfo').mockResolvedValue({
+				owner: 'testowner',
+				name: 'testrepo',
+			})
+
+			const mockSettings = {
+				agents: {
+					'test-agent': {
+						model: 'haiku',
+					},
+				},
+			}
+
+			const mockSettingsManager = {
+				loadSettings: vi.fn().mockResolvedValue(mockSettings),
+			}
+
+			const mockAgentManager = {
+				loadAgents: vi.fn().mockResolvedValue({
+					'test-agent': {
+						description: 'Test agent',
+						prompt: 'Test prompt',
+						tools: ['Read'],
+						model: 'haiku', // Overridden by settings
+					},
+				}),
+				formatForCli: vi.fn((agents) => agents),
+			}
+
+			const originalCwd = process.cwd
+			process.cwd = vi.fn().mockReturnValue('/path/to/feat/issue-123-test')
+
+			const commandWithSettings = new IgniteCommand(
+				mockTemplateManager,
+				mockGitWorktreeManager,
+				mockAgentManager as never,
+				mockSettingsManager as never,
+			)
+
+			try {
+				await commandWithSettings.execute()
+
+				const launchClaudeCall = launchClaudeSpy.mock.calls[0]
+				expect(launchClaudeCall[1]).toHaveProperty('agents')
+				expect(launchClaudeCall[1].agents).toEqual({
+					'test-agent': {
+						description: 'Test agent',
+						prompt: 'Test prompt',
+						tools: ['Read'],
+						model: 'haiku', // Should reflect the override
+					},
+				})
+			} finally {
+				process.cwd = originalCwd
+				launchClaudeSpy.mockRestore()
+				getRepoInfoSpy.mockRestore()
+			}
+		})
+	})
 })

src/commands/ignite.ts

@@ -6,6 +6,7 @@ import { launchClaude, ClaudeCliOptions } from '../utils/claude.js'
 import { PromptTemplateManager, TemplateVariables } from '../lib/PromptTemplateManager.js'
 import { getRepoInfo } from '../utils/github.js'
 import { AgentManager } from '../lib/AgentManager.js'
+import { SettingsManager } from '../lib/SettingsManager.js'
 
 /**
  * IgniteCommand: Auto-detect workspace context and launch Claude
@@ -23,15 +24,18 @@ export class IgniteCommand {
 	private templateManager: PromptTemplateManager
 	private gitWorktreeManager: GitWorktreeManager
 	private agentManager: AgentManager
+	private settingsManager: SettingsManager
 
 	constructor(
 		templateManager?: PromptTemplateManager,
 		gitWorktreeManager?: GitWorktreeManager,
-		agentManager?: AgentManager
+		agentManager?: AgentManager,
+		settingsManager?: SettingsManager
 	) {
 		this.templateManager = templateManager ?? new PromptTemplateManager()
 		this.gitWorktreeManager = gitWorktreeManager ?? new GitWorktreeManager()
 		this.agentManager = agentManager ?? new AgentManager()
+		this.settingsManager = settingsManager ?? new SettingsManager()
 	}
 
 	/**
@@ -107,10 +111,24 @@ export class IgniteCommand {
 				}
 			}
 
-			// Step 4.6: Load agent configurations
+			// Step 4.6: Load project settings and agent configurations
 			let agents: Record<string, unknown> | undefined
 			try {
-				const loadedAgents = await this.agentManager.loadAgents()
+				// Load project-level settings first
+				let settings
+				try {
+					settings = await this.settingsManager.loadSettings()
+					if (settings?.agents && Object.keys(settings.agents).length > 0) {
+						logger.debug('Loaded project settings', {
+							agentOverrides: Object.keys(settings.agents),
+						})
+					}
+				} catch (error) {
+					logger.warn(`Failed to load settings: ${error instanceof Error ? error.message : 'Unknown error'}`)
+				}
+
+				// Load agents with settings overrides
+				const loadedAgents = await this.agentManager.loadAgents(settings)
 				agents = this.agentManager.formatForCli(loadedAgents)
 				logger.debug('Loaded agent configurations', {
 					agentCount: Object.keys(agents).length,