hb feedback should report the detected 'capabilties' in the diagnotic info (i.e web,cli) as well as claude CLI version number if available

[acreeger]

Enhancement Analysis

Problem Summary
The hb feedback command's diagnostic information is missing key environment details: the detected capabilities (web/CLI modes) and Claude CLI version number.

User Impact
Developers using the feedback command receive incomplete diagnostic information, making it harder to troubleshoot issues or understand the environment context when reporting problems.

Enhancement Goal
Extend the diagnostic output to include capability detection results (web, CLI) and the Claude CLI version number when available, providing more complete environment context for debugging and support.

Next Steps

• Technical analysis to identify where capability detection occurs
• Implementation planning to add capability info and Claude version to diagnostic output
• Testing to verify new fields appear correctly in feedback command

---

📋 Complete Context & Details (click to expand)

Additional Context

• The hb feedback command already gathers diagnostic information
• Capability detection (web vs CLI modes) exists in the codebase but isn't currently included in feedback output
• Claude CLI version information would be valuable when available but should gracefully handle cases where Claude CLI isn't installed
• This enhancement improves the quality of diagnostic information for troubleshooting workflows

[acreeger]

Complexity Assessment

Classification: SIMPLE

Metrics:

• Estimated files affected: 2
• Estimated lines of code: 40-50
• Breaking changes: No
• Database migrations: No
• Cross-cutting changes: No
• File architecture quality: Good (both files <150 LOC, clear single concerns)
• Overall risk level: Low

Reasoning: This is a straightforward enhancement requiring modifications to only 2 well-architected files. The required functionality (capability detection via ProjectCapabilityDetector and Claude version via getClaudeVersion()) already exists in the codebase. Implementation involves adding 2 fields to the DiagnosticInfo interface, extending gatherDiagnosticInfo() to populate these fields, and updating the markdown formatting. No breaking changes, no cross-cutting concerns, and minimal code complexity.

Supporting Details:

Item	Details
Files to modify	2: diagnostics.ts (127 LOC), feedback.ts (76 LOC)
Estimated implementation LOC	40-50 lines
Dependencies available	Yes - ProjectCapabilityDetector and getClaudeVersion() already implemented
Architecture quality	Good - both files have clear, single responsibilities
Risk assessment	Low - additive changes only, no behavioral modifications
Breaking changes	No

[acreeger]

Combined Analysis & Plan - Issue #179

Executive Summary

Add capability detection (web/CLI modes) and Claude CLI version to the hb feedback command's diagnostic output. Both required functions already exist in codebase - straightforward addition of 2 new fields to DiagnosticInfo interface and corresponding formatting changes.

Questions and Key Decisions

Question	Answer
Should capabilities default to empty array if detection fails?	Yes - ProjectCapabilityDetector already returns empty array on failure; maintain consistency
Should claudeVersion be null or "not available" string when CLI not found?	null - Maintains type consistency with getClaudeVersion() return type; formatting will handle null display
Where should ProjectCapabilityDetector be instantiated?	In gatherDiagnosticInfo() - Keep same pattern as other diagnostic gathering, no global instance needed
Should we detect capabilities in current directory or project root?	Current directory (process.cwd()) - Feedback command runs from user's location

Implementation Overview

High-Level Execution Phases

1. Update DiagnosticInfo interface - Add capabilities and claudeVersion fields
2. Enhance gatherDiagnosticInfo() - Instantiate ProjectCapabilityDetector and call detection methods
3. Update formatDiagnosticsAsMarkdown() - Add new rows for capabilities and Claude version
4. Add test coverage - Test new fields in both gathering and formatting functions

Quick Stats

• 2 files to modify
• 0 new files to create
• 0 files to delete
• Dependencies: None (all utilities already exist)

---

📋 Complete Analysis & Implementation Details (click to expand)

Analysis Findings

Affected Files

• /src/utils/diagnostics.ts:13-19 - DiagnosticInfo interface definition
• /src/utils/diagnostics.ts:25-35 - gatherDiagnosticInfo() function implementation
• /src/utils/diagnostics.ts:40-57 - formatDiagnosticsAsMarkdown() function implementation
• /src/utils/diagnostics.test.ts - Test suite requiring new test cases

Integration Points

• ProjectCapabilityDetector from /src/lib/ProjectCapabilityDetector.ts:9 - Returns capabilities array and binEntries
• getClaudeVersion() from /src/utils/claude.ts:45 - Returns string | null for Claude CLI version
• Both functions handle errors gracefully with appropriate fallback values

---

Implementation Plan

Automated Test Cases to Create

Test File: /src/utils/diagnostics.test.ts (MODIFY)

Add to gatherDiagnosticInfo describe block:

it('should include capabilities field with detected project types', async () => {
  // Test that capabilities array is populated
  // Verify it contains valid ProjectCapability values ('cli' or 'web')
})

it('should include claudeVersion field when Claude CLI is available', async () => {
  // Test that claudeVersion is populated when getClaudeVersion() succeeds
  // Verify string format matches expected pattern
})

it('should handle claudeVersion as null when Claude CLI not available', async () => {
  // Test graceful handling when Claude CLI not found
  // Verify null value is acceptable
})

Add to formatDiagnosticsAsMarkdown describe block:

it('should include capabilities in markdown output', () => {
  // Test with both 'cli' and 'web' capabilities
  // Verify formatted as comma-separated string in table
})

it('should handle empty capabilities array', () => {
  // Test with empty array
  // Verify displays "none" or similar
})

it('should include Claude CLI version when available', () => {
  // Test with version string like "1.2.3"
  // Verify appears in table row
})

it('should display "not available" when claudeVersion is null', () => {
  // Test with null claudeVersion
  // Verify user-friendly fallback text
})

Files to Modify

1. /src/utils/diagnostics.ts:13-19

Change: Add capabilities and claudeVersion fields to DiagnosticInfo interface

export interface DiagnosticInfo {
  cliVersion: string
  nodeVersion: string
  osType: string
  osVersion: string
  architecture: string
  capabilities: ProjectCapability[]  // NEW
  claudeVersion: string | null      // NEW
}

2. /src/utils/diagnostics.ts:1-5

Change: Add imports for ProjectCapabilityDetector and getClaudeVersion
Cross-cutting impact: None - standard import addition

import { readFile } from 'fs/promises'
import { join, dirname } from 'path'
import { fileURLToPath } from 'url'
import { platform, release, arch } from 'os'
import { logger } from './logger'
import { ProjectCapabilityDetector } from '../lib/ProjectCapabilityDetector.js'  // NEW
import type { ProjectCapability } from '../types/hatchbox.js'                    // NEW
import { getClaudeVersion } from './claude.js'                                    // NEW

3. /src/utils/diagnostics.ts:25-35

Change: Instantiate ProjectCapabilityDetector and gather capabilities and Claude version
Cross-cutting impact: None - self-contained function update

export async function gatherDiagnosticInfo(): Promise<DiagnosticInfo> {
  // Instantiate detector for current directory
  const detector = new ProjectCapabilityDetector()
  const { capabilities } = await detector.detectCapabilities(process.cwd())
  
  // Get Claude CLI version (returns null if not available)
  const claudeVersion = await getClaudeVersion()

  const diagnostics: DiagnosticInfo = {
    cliVersion: await getCliVersion(),
    nodeVersion: getNodeVersion(),
    osType: getOsType(),
    osVersion: getOsVersion(),
    architecture: getArchitecture(),
    capabilities,      // NEW
    claudeVersion,     // NEW
  }

  return diagnostics
}

4. /src/utils/diagnostics.ts:40-57

Change: Add table rows for capabilities and Claude version in markdown output

export function formatDiagnosticsAsMarkdown(diagnostics: DiagnosticInfo, includeMarker = true): string {
  const marker = includeMarker ? `<!-- CLI GENERATED FEEDBACK v${diagnostics.cliVersion} -->\n` : ''
  
  // Format capabilities as comma-separated string or "none"
  const capabilitiesDisplay = diagnostics.capabilities.length > 0 
    ? diagnostics.capabilities.join(', ') 
    : 'none'
  
  // Format Claude version with fallback for null
  const claudeVersionDisplay = diagnostics.claudeVersion ?? 'not available'

  return `${marker}
<details>
<summary>Diagnostic Information</summary>

| Property | Value |
|----------|-------|
| CLI Version | ${diagnostics.cliVersion} |
| Node.js Version | ${diagnostics.nodeVersion} |
| OS | ${diagnostics.osType} |
| OS Version | ${diagnostics.osVersion} |
| Architecture | ${diagnostics.architecture} |
| Capabilities | ${capabilitiesDisplay} |
| Claude CLI Version | ${claudeVersionDisplay} |

</details>
`
}

5. /src/utils/diagnostics.test.ts

Change: Add test cases for new fields
Cross-cutting impact: None - test coverage only

Add test cases as specified in "Automated Test Cases to Create" section above.

Detailed Execution Order

Phase 1: Update Interface and Types

1. Modify DiagnosticInfo interface → Verify: TypeScript compilation succeeds
2. Add import statements → Verify: No import errors

Phase 2: Implement Diagnostic Gathering

1. Update gatherDiagnosticInfo() to instantiate ProjectCapabilityDetector → Verify: Function compiles
2. Add capabilities detection call → Verify: Returns ProjectCapabilities object
3. Add getClaudeVersion() call → Verify: Returns string | null
4. Add fields to diagnostics object → Verify: Type checking passes

Phase 3: Update Formatting

1. Add capability formatting logic → Verify: Empty array displays "none"
2. Add claudeVersion formatting logic → Verify: null displays "not available"
3. Add table rows to markdown output → Verify: Markdown structure valid

Phase 4: Test Coverage

1. Add tests for capabilities field in gatherDiagnosticInfo → Verify: Tests pass
2. Add tests for claudeVersion field in gatherDiagnosticInfo → Verify: Tests pass
3. Add tests for capabilities formatting → Verify: Tests pass
4. Add tests for claudeVersion formatting → Verify: Tests pass
5. Run full test suite → Verify: All existing tests still pass

Phase 5: Validation

1. Run pnpm typecheck → Verify: No type errors
2. Run pnpm test → Verify: All tests pass with new coverage
3. Manual test: Run hb feedback "test message" → Verify: New fields appear in GitHub issue

---

Status: ✅ Complete

Combined analysis and planning completed successfully. Ready for implementation phase.

[acreeger]

Implementation Complete - Issue #179 ✅

Summary

Added capability detection (cli/web modes) and Claude CLI version to the hb feedback command's diagnostic output, providing more complete environment context for debugging and support.

Changes Made

• diagnostics.ts: Extended DiagnosticInfo interface with capabilities and claudeVersion fields, updated gathering and formatting functions
• diagnostics.test.ts: Added comprehensive test coverage for new fields including edge cases for empty arrays and null values

Validation Results

• ✅ Tests: All tests passed (531 total)
• ✅ Typecheck: Passed
• ✅ Lint: Passed

---

📋 Detailed Changes by File (click to expand)

Files Modified

/src/utils/diagnostics.ts

Changes: Added capabilities and claudeVersion fields to diagnostic collection and markdown output

• Added imports for ProjectCapabilityDetector, ProjectCapability type, and getClaudeVersion
• Extended DiagnosticInfo interface with capabilities (ProjectCapability[]) and claudeVersion (string | null) fields
• Updated gatherDiagnosticInfo() to instantiate ProjectCapabilityDetector and call detectCapabilities()
• Updated gatherDiagnosticInfo() to call getClaudeVersion()
• Updated formatDiagnosticsAsMarkdown() to display capabilities as comma-separated list or "none"
• Updated formatDiagnosticsAsMarkdown() to display Claude version or "not available"

/src/utils/diagnostics.test.ts

Changes: Added test coverage for new diagnostic fields

• Updated mock DiagnosticInfo object to include capabilities and claudeVersion
• Added test: "should include capabilities field as an array"
• Added test: "should include claudeVersion field as string or null"
• Added test: "should display 'none' for empty capabilities array"
• Added test: "should display 'not available' when claudeVersion is null"
• Added test: "should format multiple capabilities as comma-separated string"
• Added test: "should format single capability correctly"
• Updated existing tests to verify new fields appear in diagnostic output

Test Coverage Added

All new functionality covered by automated tests:

• Capability detection integration (array type validation)
• Claude version detection (string | null type validation)
• Empty capabilities formatting ("none" display)
• Null Claude version formatting ("not available" display)
• Multiple capabilities formatting ("cli, web" display)
• Single capability formatting ("cli" display)