Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzip #8

Closed
oyvindln opened this issue Dec 4, 2016 · 6 comments
Closed

gzip #8

oyvindln opened this issue Dec 4, 2016 · 6 comments

Comments

@oyvindln
Copy link
Collaborator

oyvindln commented Dec 4, 2016

Implement support for compression with a gzip header/trailer.
@ghost
Copy link

ghost commented Feb 16, 2017

👍, any progress on this?

@oyvindln
Copy link
Collaborator Author

It's not something I have focused yet. I was planning to look at it after I've fixed the block splitting behaviour to emulate that of miniz/zlib (mostly done), and #7 (as these things don't require any API change).

My idea for this issue was to use the code from flate2 to create a crate for gzip headers as suggested here and use that. It should be relatively simple to implement as the gzip bits are after all just metadata and a checksum, and there are already crates for the checksum algorithm (CRC-32). Of course, anyone is welcome to contribute and it's very motivating to see someone interested in this.

@oyvindln
Copy link
Collaborator Author

Fixed in 8268a67

@ghost
Copy link

ghost commented Apr 26, 2017

Awesome! Thanks!

@ghost
Copy link

ghost commented Apr 26, 2017

You might want to update the README and state that the library is pure-Rust

@oyvindln
Copy link
Collaborator Author

It sort of says already, but I guess I could make it a bit clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oyvindln