regression between GSL/3.1 and GSL/4.1

[suntong]

Hi,

I found out some regressions between GSL/3.1 and GSL/4.1, and have put my code under
https://github.com/suntong001/gsl/tree/master/doc/examples

Files:

1. regression-gsl.gsl
2. regression-case1.xml
3. regression-case2.xml

Here is how they behave under GSL/3.1:

$ gsl -script:regression-gsl.gsl regression-case1.xml 
2013/12/25 23:14:40: GSL/3.1 Copyright (c) 1991-2003 iMatix Corporation
2013/12/25 23:14:40: gsl3 I: Processing regression-case1.xml...
2013/12/25 23:14:40: gsl3 M: is empty

$ gsl -script:regression-gsl.gsl regression-case2.xml 
2013/12/25 23:14:44: GSL/3.1 Copyright (c) 1991-2003 iMatix Corporation
2013/12/25 23:14:44: gsl3 I: Processing regression-case2.xml...
2013/12/25 23:14:44: gsl3 M: not empty
Test

In GSL/4.1 (https://github.com/imatix/gsl), it just errors out.

Please verify.
Thanks

[jschultz]

Hi,

Thanks for showing us this. If would help if you could provide more detail when you say that gsl4 'errors out', but no matter.

I can see two issues here. First is that GSL4 rejects a line of gsl code that begins with a tab followed by a direct output ('>') operator. This clearly a bug in the GSL parser, and not much effort to fix.

The second is that GSL4 and GSL3 treat 'defined (options->code->BEGIN)' differently. In GSL3 this was exactly equivalent to 'defined (options->code->BEGIN.)' (ie with the additional dot). In GSL4 we changed this to reflect more accurately the fact that in this instance 'options->code->BEGIN' IS defined, as an empty XML item, while 'options->code->BEGIN.' is not defined.

Hope this makes sense and is of help.

Jonathan

-----Original Message-----
From: suntong001 [email protected]
To: imatix/gsl [email protected]
Sent: Thu, 26 Dec 2013 15:23
Subject: [gsl] regression between GSL/3.1 and GSL/4.1 (#19)

Hi,

I found out some regressions between GSL/3.1 and GSL/4.1, and have put my code under

https://github.com/suntong001/gsl/tree/master/doc/examples

Files:

regression-gsl.gslregression-case1.xmlregression-case2.xml

Here is how they behave under GSL/3.1:

$ gsl -script:regression-gsl.gsl regression-case1.xml 2013/12/25 23:14:40: GSL/3.1 Copyright (c) 1991-2003 iMatix Corporation 2013/12/25 23:14:40: gsl3 I: Processing regression-case1.xml... 2013/12/25 23:14:40: gsl3 M: is empty $ gsl -script:regression-gsl.gsl regression-case2.xml 2013/12/25 23:14:44: GSL/3.1 Copyright (c) 1991-2003 iMatix Corporation 2013/12/25 23:14:44: gsl3 I: Processing regression-case2.xml... 2013/12/25 23:14:44: gsl3 M: not empty Test

In GSL/4.1 (https://github.com/imatix/gsl), it just errors out.

Please verify.

Thanks

—
Reply to this email directly or view it on GitHub.

[suntong]

Wow, I wasn't expecting that anyone else would be as "crazy" as me working during Christmas time.
Thanks a lot for the swift reply Jonathan!

Yep, you're spot on about the two issues that I wanted to report. Thanks for the detailed explanation about the second one. Yes, that does make perfect sense.

Please fix the first one at your convenient.

Thanks