-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wish: Migrate to System.Text.Json instead of newtonsoft #82
Comments
It's used for all JSON serialization in the Imageflow .NET wrapper, so
migrating that library first would make sense. I think I opened an issue
for thar goal, but haven't had time yet.
…On Mon, Jul 3, 2023, 11:50 PM iJungleboy ***@***.***> wrote:
ATM it appears that Newtonsoft is still being used, but I think only in
the watermark (but I'm not sure).
Since we like keeping our third-party dependencies as clean as possible, I
would like to ask to migrate to System.Text.Json instead. I believe it's a
very small change.
@tvatavuk <https://github.com/tvatavuk> fyi
—
Reply to this email directly, view it on GitHub
<#82>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2LHZARARKUNAXJKP7MLLXOLL2HANCNFSM6AAAAAAZ4SDEUU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@lilith no problem, been there all the time 😉. Thanks for everything. |
It's definitely something I want to have changed, but probably more
integration tests would be needed.
…On Tue, Jul 4, 2023, 3:31 PM iJungleboy ***@***.***> wrote:
@lilith <https://github.com/lilith> no problem, been there all the time 😉.
Thanks for everything.
—
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2LH7G4TQ7IDXD6KHORMDXOO2DPANCNFSM6AAAAAAZ4SDEUU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ATM it appears that Newtonsoft is still being used, but I think only in the watermark (but I'm not sure).
Since we like keeping our third-party dependencies as clean as possible, I would like to ask to migrate to System.Text.Json instead. I believe it's a very small change.
@tvatavuk fyi
The text was updated successfully, but these errors were encountered: