Reintroduce static analysis using PHPStan

Author: christeredvartsen

.github/CONTRIBUTING.md

@@ -15,6 +15,10 @@ After this has been started you can execute the test suites by running:
     ./vendor/bin/behat --strict
     ./vendor/bin/phpunit
 
+[PHPStan](https://phpstan.org/) is used for static code analysis:
+
+    vendor/bin/phpstan
+
 ## Documentation
 
 The extension uses [Sphinx](http://www.sphinx-doc.org/en/stable/) for documentation, and all end-user documentation resides in the `docs` directory. To generate the current documentation after checking out your fork simply run the `docs` composer script:

.github/workflows/ci.yml

@@ -50,6 +50,9 @@ jobs:
       - name: Run integration tests
         run: vendor/bin/behat --strict
 
+      - name: Run static code analysis
+        run: vendor/bin/phpstan
+
       - name: Check coding standard
         run: php-cs-fixer fix --dry-run --diff
         env:

composer.json

@@ -28,6 +28,7 @@
   },
   "require-dev": {
     "imbo/imbo-coding-standard": "^2.0",
+    "phpstan/phpstan": "^2.1",
     "phpunit/phpunit": "^11.5",
     "slim/psr7": "^1.3",
     "slim/slim": "^4.7",
@@ -48,6 +49,7 @@
     "ci": [
       "@phpunit",
       "@behat",
+      "@sa",
       "@cs"
     ],
     "test": [
@@ -57,6 +59,7 @@
     "phpunit": "vendor/bin/phpunit",
     "phpunit:coverage": "vendor/bin/phpunit --coverage-html build/coverage",
     "behat": "vendor/bin/behat --strict",
+    "sa": "vendor/bin/phpstan",
     "cs": "php-cs-fixer fix --dry-run --diff",
     "dev": "php -S localhost:8080 -t ./features/bootstrap > server.log 2>&1",
     "docs": "cd docs; make html"

composer.lock

@@ -38,7 +38,7 @@ public static function getArraysAndLengths(): array
     }
 
     /**
-     * @return array<array{array:array<int>,maxLength:int,message:string}>
+     * @return array<array{list:array<int>,maxLength:int,message:string}>
      */
     public static function getValuesThatFail(): array
     {

tests/ArrayContainsComparator/Matcher/ArrayLengthTest.php

@@ -92,7 +92,7 @@ public static function getHttpMethods(): array
     }
 
     /**
-     * @return array<array{code:int,others:array<int>}>
+     * @return array<array{code:int}>
      */
     public static function getResponseCodes(): array
     {