Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix low-impact potential race condition #20

Open
zplizzi opened this issue Jul 28, 2021 · 0 comments
Open

Fix low-impact potential race condition #20

zplizzi opened this issue Jul 28, 2021 · 0 comments

Comments

@zplizzi
Copy link
Contributor

zplizzi commented Jul 28, 2021

Consider this execution order:

  • User calls this script, and the sync_send line runs to completion
  • User separately changes the code and then calls a command to sync code. That code runs to completion
  • The send line here executes

That means that the NEW code will be executed, ie, the execute request is not atomic.

In practice it's probably not a huge deal, but it seems like it would both be safer and simpler if we had only a single request type, and that request executed atomically (either to update the code and then execute the cell, in the case or this script, or to just update the code, in the case of the other script)

@zplizzi zplizzi mentioned this issue Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant