Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short_description is missing ? #21

Open
DevSide opened this issue May 26, 2023 · 2 comments
Open

short_description is missing ? #21

DevSide opened this issue May 26, 2023 · 2 comments

Comments

@DevSide
Copy link

DevSide commented May 26, 2023

short_description field is missing on "gif-q" feature (maybe some other) which makes @imgix/gatsby throws here:
https://github.com/imgix/gatsby/blob/main/src/modules/gatsby-plugin/graphqlTypes.ts#L59

Either this is a required field and should be fix here, or @imgix/gatsby should handle it optionally.

@DevSide DevSide changed the title short_description missing short_description is missing ? May 26, 2023
@luqven
Copy link
Contributor

luqven commented May 26, 2023

Hey @DevSide 👋🏼 , thanks for opening this issue.

The latest release, @imgix/gatsby@latest, should resolve this issue. If you're still experiencing problems, either open a new issue on imgix/gatsby or add a comment to this issue, and we'll be sure to re-open it.

As far as the field missing, we're looking at adding short_description to gif-q and will update this issue once that's resolved.

Please let us know if you have any further issues or questions.

@JuhG
Copy link

JuhG commented Sep 27, 2023

Hey @luqven!
It might be fixed in the latest version, but unfortunately we're still on v1, and it's definitely not fixed in that version. Any chance you could fix it here or add the ? to shortDescription?.slice(-1) as a bugfix release? Happy to help with a PR if that helps.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants