Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types for params #308

Open
sylcastaing opened this issue Dec 14, 2021 · 3 comments
Open

Typescript types for params #308

sylcastaing opened this issue Dec 14, 2021 · 3 comments

Comments

@sylcastaing
Copy link
Contributor

sylcastaing commented Dec 14, 2021

Hello team,

All my company's projects that use Imgix are written in typescript.
Before, we use react-imgix with @types/react-imgix.

In @types/react-imgix there are type for all Imgix Params types. Not pretty but it's good for IDE autocompletation and help very much my team.

What do you think about port the types of imgixParams to js-core ?

It can be usefull to have, in the future, embed types pointing to js-core typing for all others projets (react-imgix, angular, etc..)

I can, of course, make a PR for this !

@sylcastaing
Copy link
Contributor Author

Oh, I read the angular projet code and typing of params is generated with imgix-url-params project.

It may be a solution.

@frederickfogerty
Copy link
Contributor

Salut @sylcastaing, just letting you know that I didn't miss this, and we're still discussing this internally. Of course we'd love a PR for this if you have the time!

@frederickfogerty
Copy link
Contributor

Hi @sylcastaing 👋 we would love to have some type params for imgixParams in js-core. The way we would like to implement it would be to add a .d.ts file to https://github.com/imgix/imgix-url-params, in the dist folder, and then import those definitions here, and also in react and angular. We prefer the react-style typings, so we will be looking to copy those over. If this sounds like something you're interested in helping out with, let me know!

@luqven luqven added the hacktoberfest Good first issue for hacktober contributors label Sep 28, 2022
@luqven luqven added help wanted and removed hacktoberfest Good first issue for hacktober contributors labels Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants