Merge pull request #37 from imliam/handle-quoted-characters

#21 Handle quoted values

Author: imliam

src/EnvironmentSetCommand.php

@@ -80,8 +80,9 @@ public function setEnvVariable(string $envFileContent, string $key, string $valu
         $oldPair = $this->readKeyValuePair($envFileContent, $key);
 
         // Wrap values that have a space or equals in quotes to escape them
-        if (preg_match('/\s/',$value) || strpos($value, '=') !== false) {
-            $value = '"' . $value . '"';
+        $trimmedValue = trim($value);
+        if (!str_starts_with($trimmedValue, '"') && !str_ends_with($trimmedValue, '"') && preg_match('/\s/',$value) || strpos($value, '=') !== false) {
+            $value = '"' . str_replace('"', '\"', $value) . '"';
         }
 
         $newPair = $key . '=' . $value;

tests/Unit/EnvironmentSetCommandTest.php

@@ -70,6 +70,19 @@ public function testWhitespaceAsValueDoesntCreateNewEntry(): void
         $this->assertEquals($expectedEnv, $newEnv);
     }
 
+    /**
+     * @covers EnvironmentSetCommand::setEnvVariable
+     */
+    public function testQuotedCharactersArePreserved(): void
+    {
+        $env = 'APP_NAME=' . "\n";
+
+        $expectedEnv = 'APP_NAME="MY.NAME & C."' . "\n";
+
+        [$newEnv, $_] = $this->command->setEnvVariable($env, 'APP_NAME', 'MY.NAME & C.');
+        $this->assertEquals($expectedEnv, $newEnv);
+    }
+
     /**
      * @covers       EnvironmentSetCommand::readKeyValuePair
      * @dataProvider readKeyValuePairDataProvider