-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samsung Galaxy S6 incorrect display parameters #129
Comments
It would also be nice to be able to add/override display parameters for specific devices, so issues like this can be corrected manually as they are found. |
This bad value is also included in the JSON loaded from Google. So if you correct it in dpdb-cache.js, you should also call Dpdb(false, ...) to not load the bad JSON values. There's a bunch of other asymmetric dpi pairs and google even left out their new PIXELs. And some newer SAMSUNG phones can be set to GAME MODE, reporting 1920x1080 instead of 2560x1440. Could please someone at GOOGLE fix the https://storage.googleapis.com/cardboard-dpdb/dpdb.json accordingly. |
I'm not getting a match at all for my S6, even an incorrect one. I think the Samsung ua rules are overly strict, as there may be multiple UA strings for all the different variants of the phone. |
Could you try immersive-web/webvr-polyfill-dpdb#9 on this device and report back some info? We can currently match via resolution instead of user agent (like iOS devices) with a looser UA string and match both via |
@jsantell Is there a site or utility for checking that? |
Oh, I see it now... |
@jsantell Here's what I got: Not sure about bezel width, but I understand the device dimensions are: |
I think if my math is right, the bezel is 3.8 or ~4. What's the user agent string? I'd think that the SM-G925F would match that device.. |
Moving Samsung resolution handling to fix incorrect distortions to immersive-web/cardboard-vr-display#7 |
The Galaxy S6 reports xdpi=522.5 and ydpi=576.6, resulting in incorrect distortion which is not radially symmetric.
The text was updated successfully, but these errors were encountered: