Add versioning fields to editable join tables

Author: parndt

app/models/measure_category.rb

@@ -1,4 +1,4 @@
-class MeasureCategory < ApplicationRecord
+class MeasureCategory < VersionedRecord
   belongs_to :measure
   belongs_to :category
   accepts_nested_attributes_for :measure

app/serializers/measure_category_serializer.rb

@@ -1,5 +1,5 @@
 class MeasureCategorySerializer
-  include FastApplicationSerializer
+  include FastVersionedSerializer
 
   attributes :measure_id, :category_id
 

app/serializers/user_role_serializer.rb

@@ -1,5 +1,5 @@
 class UserRoleSerializer
-  include FastApplicationSerializer
+  include FastVersionedSerializer
 
   attributes :user_id, :role_id
 

db/migrate/20180528083426_add_last_modified_user_id_to_versioned_records.rb

@@ -29,6 +29,7 @@ def down
     Page,
     ProgressReport,
     Recommendation,
+    Sdgtarget,
     Taxonomy,
     User,
     UserRole

db/migrate/20220123224010_add_versioned_fields_to_joins.rb

@@ -0,0 +1,7 @@
+class AddVersionedFieldsToJoins < ActiveRecord::Migration[6.1]
+  def change
+    change_table(:measure_categories) do |t|
+      t.belongs_to :updated_by, foreign_key: {to_table: "users"}, index: true, null: true
+    end
+  end
+end

db/schema.rb

@@ -130,9 +130,9 @@
     t.text "indicator_summary"
     t.text "target_date_comment"
     t.integer "updated_by_id"
-    t.string "reference"
     t.datetime "relationship_updated_at", precision: 6
     t.bigint "relationship_updated_by_id"
+    t.string "reference"
     t.index ["draft"], name: "index_measures_on_draft"
   end
 
@@ -324,7 +324,7 @@
     t.index ["reset_password_token"], name: "index_users_on_reset_password_token", unique: true
   end
 
-  create_table "versions", id: :serial, force: :cascade do |t|
+  create_table "versions", force: :cascade do |t|
     t.string "item_type", null: false
     t.bigint "item_id", null: false
     t.string "event", null: false

spec/controllers/measure_categories_controller_spec.rb

@@ -70,6 +70,13 @@
         post :create, format: :json, params: {measure_category: {description: "desc only", taxonomy_id: 999}}
         expect(response).to have_http_status(422)
       end
+
+      it "will record what manager created the measure category", versioning: true do
+        expect(PaperTrail).to be_enabled
+        sign_in user
+        json = JSON.parse(subject.body)
+        expect(json.dig("data", "attributes", "updated_by_id").to_i).to eq user.id
+      end
     end
   end
 

spec/controllers/user_roles_controller_spec.rb

@@ -254,6 +254,21 @@
         post :create, format: :json, params: {user_role: {description: "desc only", taxonomy_id: 999}}
         expect(response).to have_http_status(422)
       end
+
+      it "will record what admin created the user role", versioning: true do
+        expect(PaperTrail).to be_enabled
+        sign_in admin
+        subject = post :create,
+          format: :json,
+          params: {
+            user_role: {
+              user_id: manager.id,
+              role_id: admin_role.id
+            }
+          }
+        json = JSON.parse(subject.body)
+        expect(json.dig("data", "attributes", "updated_by_id").to_i).to eq admin.id
+      end
     end
   end