Skip to content

Commit 53734ec

Browse files
committed
Cleaned unit tests and removed assembly signature
1 parent d6f8458 commit 53734ec

File tree

5 files changed

+60
-156
lines changed

5 files changed

+60
-156
lines changed

Directory.Build.props

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project>
3-
43
<!-- General information -->
54
<PropertyGroup>
65
<Authors>Ugo Lattanzi</Authors>
@@ -90,6 +89,12 @@
9089
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
9190
</PropertyGroup>
9291

92+
<ItemGroup>
93+
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
94+
<_Parameter1>$(MSBuildProjectName).Tests</_Parameter1>
95+
</AssemblyAttribute>
96+
</ItemGroup>
97+
9398
<ItemGroup>
9499
<AssemblyAttribute Include="System.Diagnostics.CodeAnalysis.SuppressMessage">
95100
<_Parameter1>Style</_Parameter1>

src/aspnet/StackExchange.Redis.Extensions.AspNetCore/StackExchange.Redis.Extensions.AspNetCore.csproj

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,6 @@
88
<Nullable>enable</Nullable>
99
</PropertyGroup>
1010

11-
<!-- Assembly signing -->
12-
<PropertyGroup>
13-
<AssemblyOriginatorKeyFile>..\..\StackExchange.Redis.Extensions.Core.snk</AssemblyOriginatorKeyFile>
14-
<SignAssembly>true</SignAssembly>
15-
</PropertyGroup>
16-
1711
<ItemGroup>
1812
<FrameworkReference Include="Microsoft.AspNetCore.App" />
1913
<ProjectReference Include="..\..\core\StackExchange.Redis.Extensions.Core\StackExchange.Redis.Extensions.Core.csproj" />

src/core/StackExchange.Redis.Extensions.Core/StackExchange.Redis.Extensions.Core.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
<!-- Assembly signing -->
44
<PropertyGroup>
5-
<AssemblyOriginatorKeyFile>..\..\StackExchange.Redis.Extensions.Core.snk</AssemblyOriginatorKeyFile>
6-
<SignAssembly>true</SignAssembly>
75
<Nullable>enable</Nullable>
86
</PropertyGroup>
97

tests/StackExchange.Redis.Extensions.Core.Tests/CacheClientTestBase.Hash.cs

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System.Collections.Generic;
55
using System.Threading.Tasks;
66

7+
using StackExchange.Redis.Extensions.Core.Helpers;
78
using StackExchange.Redis.Extensions.Core.Tests.Helpers;
89

910
using Xunit;
@@ -88,13 +89,13 @@ public async Task HashSetMultipleValues_HashGetMultipleValues_ShouldInsert_Async
8889
await Sut.GetDefaultDatabase().HashSetAsync(hashKey, map);
8990
await Task.Delay(1000);
9091

92+
var keys = map.Keys.ToFastArray(x => (RedisValue)x);
93+
9194
// assert
92-
var data = (await db
93-
.HashGetAsync(hashKey, map.Keys.Select(x => (RedisValue)x).ToArray()))
94-
.ToList()
95-
.ConvertAll(x => serializer.Deserialize<TestClass<DateTime>>(x!));
95+
var data = (await db.HashGetAsync(hashKey, keys))
96+
.ToFastArray(x => serializer.Deserialize<TestClass<DateTime>>(x!));
9697

97-
Assert.Equal(map.Count, data.Count);
98+
Assert.Equal(map.Count, data.Length);
9899

99100
foreach (var val in data)
100101
Assert.True(map.ContainsValue(val!), $"result map doesn't contain value: {val}");
@@ -443,8 +444,8 @@ var values
443444

444445
foreach (var key in values.Keys)
445446
{
446-
Assert.True(resultEnum.ContainsKey(key!));
447-
Assert.Equal(values[key], resultEnum[key!]);
447+
Assert.True(resultEnum.ContainsKey(key));
448+
Assert.Equal(values[key], resultEnum[key]);
448449
}
449450
}
450451

@@ -466,12 +467,12 @@ var values
466467
// assert
467468
Assert.NotNull(result);
468469
var resultEnum = result.ToDictionary(x => x.Key, x => x.Value);
469-
Assert.Equal(values.Keys.Count(x => x!.StartsWith('2')), resultEnum.Count);
470+
Assert.Equal(values.Keys.Count(x => x.StartsWith('2')), resultEnum.Count);
470471

471-
foreach (var key in values.Keys.Where(x => x!.StartsWith('2')))
472+
foreach (var key in values.Keys.Where(x => x.StartsWith('2')))
472473
{
473-
Assert.True(resultEnum.ContainsKey(key!));
474-
Assert.Equal(values[key], resultEnum[key!]);
474+
Assert.True(resultEnum.ContainsKey(key));
475+
Assert.Equal(values[key], resultEnum[key]);
475476
}
476477
}
477478
}

0 commit comments

Comments
 (0)